From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/3] test: py: linux: remove test_ prefix for intermediate functions
Date: Fri, 13 Feb 2026 11:35:58 +0100 [thread overview]
Message-ID: <20260213103626.2807840-4-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260213103626.2807840-1-a.fatoum@pengutronix.de>
From: Ahmad Fatoum <a.fatoum@barebox.org>
These functions are not standalone tests, but they are called from
actual tests, so rename them to prevent pytest from collecting them.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
test/py/test_linux_efiloader.py | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/test/py/test_linux_efiloader.py b/test/py/test_linux_efiloader.py
index df50f21bffc0..a76e55a91e52 100644
--- a/test/py/test_linux_efiloader.py
+++ b/test/py/test_linux_efiloader.py
@@ -72,10 +72,10 @@ def test_boot_manual_with_initrd(strategy, barebox, env, efiloader, debian_iso):
"\n".join(dmesg)) is not None
if efiloader:
- test_efi_kernel_no_warn(shell)
- test_expected_efi_messages(shell, env)
- test_efi_systab(shell, env)
- test_efivars_filesystem_not_empty(shell)
+ check_efi_kernel_no_warn(shell)
+ check_expected_efi_messages(shell, env)
+ check_efi_systab(shell, env)
+ check_efivars_filesystem_not_empty(shell)
assert not uefi_not_found, \
"EFI stub was not used despite global.bootm.efi=required"
@@ -85,15 +85,13 @@ def test_boot_manual_with_initrd(strategy, barebox, env, efiloader, debian_iso):
"EFI stub was used despite global.bootm.efi=disabled"
-@pytest.mark.lg_feature(['bootable', 'efi'])
-def test_efi_kernel_no_warn(shell):
- stdout, stderr, ret = shell.run("dmesg -r | grep '<[0-4]>.*\\<efi\\>'")
+def check_efi_kernel_no_warn(shell):
+ stdout, stderr, _ = shell.run("dmesg -r | grep '<[0-4]>.*\\<efi\\>'")
assert stdout == []
assert stderr == []
-@pytest.mark.lg_feature(['bootable', 'efi'])
-def test_expected_efi_messages(shell, env):
+def check_expected_efi_messages(shell, env):
dmesg = get_dmesg(shell, 'efi')
expected_patterns = [
@@ -106,8 +104,7 @@ def test_expected_efi_messages(shell, env):
f"Missing expected EFI message: {pattern}"
-@pytest.mark.lg_feature(['bootable', 'efi'])
-def test_efi_systab(shell, env):
+def check_efi_systab(shell, env):
stdout, stderr, ret = shell.run("cat /sys/firmware/efi/systab")
assert ret == 0
assert stderr == []
@@ -124,9 +121,7 @@ def test_efi_systab(shell, env):
f"Missing expected entry in systab : {pattern}"
-@pytest.mark.lg_feature(['bootable', 'efi'])
-def test_efivars_filesystem_not_empty(shell):
- # Directory must not be empty
+def check_efivars_filesystem_not_empty(shell):
shell.run("mount -t efivarfs efivarfs /sys/firmware/efi/efivars")
stdout, _, ret = shell.run("ls -1 /sys/firmware/efi/efivars")
assert ret == 0
--
2.47.3
prev parent reply other threads:[~2026-02-13 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 10:35 [PATCH 0/3] test: test boot with Debian netinstaller CDROM image Ahmad Fatoum
2026-02-13 10:35 ` [PATCH 1/3] test: py: linux: use utilities available in Debian netinstall images Ahmad Fatoum
2026-02-13 10:35 ` [PATCH 2/3] test: test boot with Debian netinstaller CDROM image Ahmad Fatoum
2026-02-13 10:35 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213103626.2807840-4-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox