From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Feb 2026 09:42:26 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruBV-002G2J-2x for lore@lore.pengutronix.de; Mon, 16 Feb 2026 09:42:26 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruBV-0000sK-4r for lore@pengutronix.de; Mon, 16 Feb 2026 09:42:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=hH52wOZ0dTY8ntUGv+GXXTEbhHMmzIAHeMUjyrFCDQw=; b=vCwNl9uZLkVmauZsF6L3VWqYaN K8KLiUdfh8gvmF8ILr5Kt4qcIBcvDi8okUsyIuu2wpNG0sYlSYy4jlC9mCO6gnAe2cWuegIDO/Exs VFfcFP481N7SJWJs3ZlJ8iAtkh0qHM1dtZHJoLufNjViKT9JM/6VaItc66p4/wa3hWYtIzT6SXJI5 nflayhhJnNWZg2oGDck8To5u2y+hdR61VzUWx10IwhLmP5R7jDHErsOU51uY/PGFs3kFkp/CE/V+K 5jyV8B+yDjpvMgSHvGDNzfWenB655Lz+GRcNlnhbDqhIt4GiQBFOxuP696u2nWduGHym96b2bzc2q YzQnF5nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruB5-00000006AVo-3Nfr; Mon, 16 Feb 2026 08:41:59 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruAr-00000006APO-0e2G for barebox@lists.infradead.org; Mon, 16 Feb 2026 08:41:58 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruAp-0000dq-FR; Mon, 16 Feb 2026 09:41:43 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruAn-0012BT-2f; Mon, 16 Feb 2026 09:41:43 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vruAp-0000000EsaY-0KXQ; Mon, 16 Feb 2026 09:41:43 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Mon, 16 Feb 2026 09:41:36 +0100 Message-ID: <20260216084142.3546363-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260216_004157_862263_ABC83114 X-CRM114-Status: UNSURE ( 9.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 1/4] FIT: fix potential uninitialized read during fuzzing X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) fit_find_last_unit should return -ENOENT when conf_node is NULL instead of returning 0 without writing *out_unit, as that left the caller's unit variable uninitialized. Reported-by: GCC 14.2 -fanalyzer Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum --- common/image-fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-fit.c b/common/image-fit.c index 26bd8e265b25..104a01b73658 100644 --- a/common/image-fit.c +++ b/common/image-fit.c @@ -860,7 +860,7 @@ static int fit_find_last_unit(struct fit_handle *handle, const char *unit = NULL; if (!conf_node) - return 0; + return -ENOENT; for_each_child_of_node(conf_node, child) unit = child->name; -- 2.47.3