From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Feb 2026 09:43:23 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruCQ-002G9c-0g for lore@lore.pengutronix.de; Mon, 16 Feb 2026 09:43:23 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruCQ-0001Ro-Gb for lore@pengutronix.de; Mon, 16 Feb 2026 09:43:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NM54Hj89Ii37jdmHBHiBFe5S2Ml87TBkTSUBJXu41wA=; b=G1/ll6IeRId67YXEvAaTEPrya4 5MM2MGDiHGnLVsogbO66VczOxgevWwz+jD3hNolg1ZBz1N7WUF9rSmFmqEgPJYusOnXPdI0cNHfvM h4u7AD3axbi6HViiVghhDobXF6yh1Qi5aa5P/MztKMz9QVQ4st0Ql2FvWRDyQUScsQbnpEDTpmlFT zERsipp00qBa/S9yV+3XPmmZmXERDiZ3A3x2xKAoPC9wUVmewXchAFRvJk+N5D+Kk/xB6lqOGcLn4 Gkuk7nvomF77xEX8aQMQ+db0hJPqZ5X7FMyMGQTFY6zZUZ7JwVnSeV/FU2qf2L4LSDMtzOzqRE0eV XaezUp7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruC5-00000006AqQ-49ci; Mon, 16 Feb 2026 08:43:01 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruC0-00000006Ajo-0ojT for barebox@lists.infradead.org; Mon, 16 Feb 2026 08:42:59 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruBy-00012J-MA; Mon, 16 Feb 2026 09:42:54 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruBx-0012CG-08; Mon, 16 Feb 2026 09:42:54 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vruBy-0000000Esrv-1BWs; Mon, 16 Feb 2026 09:42:54 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Mon, 16 Feb 2026 09:42:26 +0100 Message-ID: <20260216084253.3547270-10-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216084253.3547270-1-a.fatoum@pengutronix.de> References: <20260216084253.3547270-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260216_004256_228992_340B896B X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 10/12] i2c: rk3x: fix NULL pointer dereference on repeated NACK X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) In the polling loop, if a NAKRCV interrupt triggers rk3x_i2c_stop() which sets i2c->msg to NULL, a subsequent iteration with NAKRCV still asserted will dereference the NULL msg pointer when checking I2C_M_IGNORE_NAK. Add a NULL check so that a NULL msg falls through to rk3x_i2c_stop(), which handles this case safely. Reported-by: GCC 14.2 -fanalyzer Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum --- drivers/i2c/busses/i2c-rk3x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 1fdce1c8de84..d35f3e1c15c8 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -462,7 +462,8 @@ static void rk3x_i2c_irq(struct rk3x_i2c *i2c) ipd &= ~REG_INT_NAKRCV; - if (!(i2c->msg->flags & I2C_M_IGNORE_NAK)) + if (!i2c->msg || + !(i2c->msg->flags & I2C_M_IGNORE_NAK)) rk3x_i2c_stop(i2c, -ENXIO); } -- 2.47.3