From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Feb 2026 09:47:09 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruG4-002GEM-0P for lore@lore.pengutronix.de; Mon, 16 Feb 2026 09:47:09 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruG4-00029s-FI for lore@pengutronix.de; Mon, 16 Feb 2026 09:47:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IVpJav2eW+8MVEJxzd+U3cwT6pL6HpMk37dvDDewBMg=; b=EgiJx2zkBzcrvnc72+SITW3wid ObMJJPl5TwRW6fdfbqvjQXtusrWXn5L+WA2qMti4E1EGrF14r+gJOT7bDkndX7WWM0yp0JuuGgZ5s nWvk6i3yVoZsSTRHTchzLb2BFT3OCWpHnThASw5X2sHfdyYgqwoqXmqAfBq0ISnHXWtJ73S5anMN1 2cy08Y7gNQqe7KRbgTw6AWCCM2DTnsNE8PAFrIH/JlplsJebV+6idn6TS2yF2I4i73QsrrXCrh0h6 C+trBx2qvEI79zykahIRVy7G7TF5uGlDjZRONQlXnaroGWwpVTY2INz7ZcA4XWUA4i8EC0R+8J+yv m56kYkYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruFg-00000006BRP-2AJr; Mon, 16 Feb 2026 08:46:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruFe-00000006BR4-0v70 for barebox@lists.infradead.org; Mon, 16 Feb 2026 08:46:43 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruFc-000228-H8; Mon, 16 Feb 2026 09:46:40 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruFa-0012Ct-2n; Mon, 16 Feb 2026 09:46:40 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vruBy-0000000Esrv-1aFT; Mon, 16 Feb 2026 09:42:54 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Mon, 16 Feb 2026 09:42:28 +0100 Message-ID: <20260216084253.3547270-12-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216084253.3547270-1-a.fatoum@pengutronix.de> References: <20260216084253.3547270-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260216_004642_261268_954AA0F0 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 12/12] mci: spi: initialize r1 to fix garbage return value X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) If bcnt is 0, the while loop body never executes and r1 is returned uninitialized. Initialize it to 0 (success) which is the correct result when there are no blocks to write. Reported-by: GCC 14.2 -fanalyzer Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum --- drivers/mci/mci_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mci/mci_spi.c b/drivers/mci/mci_spi.c index 3ab90d768fbd..b495cdaafcf4 100644 --- a/drivers/mci/mci_spi.c +++ b/drivers/mci/mci_spi.c @@ -172,7 +172,7 @@ static uint mmc_spi_writedata(struct mmc_spi_host *host, const void *xbuf, uint32_t bcnt, uint32_t bsize, int multi) { const uint8_t *buf = xbuf; - uint8_t r1; + uint8_t r1 = 0; uint16_t crc = 0; uint8_t tok[2]; int i; -- 2.47.3