From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Feb 2026 10:17:47 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruji-002GwS-33 for lore@lore.pengutronix.de; Mon, 16 Feb 2026 10:17:47 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruja-0007X0-B6 for lore@pengutronix.de; Mon, 16 Feb 2026 10:17:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4eAGSlYCM1WufrW/qq/LUqkXgZze7R1KGcEGJvhefn0=; b=MwoNEr5elQH0QRiRGbY+zIDsVK 37NNbyhZGiN29TC48S2K5l9iuW0OX+GK5PURfPe8txzJac9yl5LSm8vICdq7YgGgt7yR5hi885709 FM/QmbGoAhe0Umcs/veKVMoggv6hBheP2a3zlYJLH74piHbyQjJY2aRqrUTvZEz10cSER+KIRhDxT EEm1GDuglBOLwl8y3fkaE+KsxDG1XLiqV0ip2DiEwEsjyNR8vQ6My3bKYbJGmw7veEaDRzCtSLwAB mLAg7zr7lcJiIApl/AWi5p/C9zs/JX17UnVKTLUAfreYRBQvyPqIvMxcjFQqi0MEiZSazd2Dx9O8r ukL0AReA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruir-00000006EfX-1FQc; Mon, 16 Feb 2026 09:16:53 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruih-00000006ERv-0YMb for barebox@lists.infradead.org; Mon, 16 Feb 2026 09:16:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruif-0006Vd-DF; Mon, 16 Feb 2026 10:16:41 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruid-0012XE-2Z; Mon, 16 Feb 2026 10:16:41 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vruH0-0000000Eudd-41ED; Mon, 16 Feb 2026 09:48:06 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Mon, 16 Feb 2026 09:44:27 +0100 Message-ID: <20260216084758.3548990-28-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216084758.3548990-1-a.fatoum@pengutronix.de> References: <20260216084758.3548990-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260216_011643_192929_B83249D5 X-CRM114-Status: UNSURE ( 8.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 27/39] efi: loader: fix NULL pointer dereference when deleting root volume handle X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) efi_file_delete() unconditionally dereferences fh->parent->fd, but the root volume handle created by efi_open_volume() has fh->parent = NULL. If a UEFI application calls Delete() on the root handle, this crashes. Check for a NULL parent and return EFI_WARN_DELETE_FAILURE, as the root volume cannot be deleted. Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum --- efi/loader/protocols/file.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/efi/loader/protocols/file.c b/efi/loader/protocols/file.c index 93700d2d3bdc..0796b3f0c26a 100644 --- a/efi/loader/protocols/file.c +++ b/efi/loader/protocols/file.c @@ -285,6 +285,11 @@ static efi_status_t EFIAPI efi_file_delete(struct efi_file_handle *file) file_close(fh); + if (!fh->parent) { + free(fh); + return EFI_EXIT(EFI_WARN_DELETE_FAILURE); + } + ret = unlinkat(fh->parent->fd, fh->path, flags); free(fh); -- 2.47.3