From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Feb 2026 09:48:42 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruHZ-002GG3-1u for lore@lore.pengutronix.de; Mon, 16 Feb 2026 09:48:42 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruHZ-0002j6-Bu for lore@pengutronix.de; Mon, 16 Feb 2026 09:48:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wUvXutAxMxr6qOfu1tNu2E2mIjBZj5N4xqU4untsvF0=; b=DmCgRPCcwiMZPf/D4jmMFdLwzP VAsuuS4fz1fxygLZAXgWAdBPj5osijiFjGTv3LXuGhokQuqbDtIi8ltlEAPuSAtPGs27DUvNBeKTq refzoGTV8BwiKNw79QpwHP5PWQHhx48bTEVniZhQw4FJVCAX179faZ/h0fsv+iO3wwqg4dzQc7K6u TBvZa8x3Bk8VL6EkZXiG+eMWGTxGJimQ2/yIpnb35MWl+7N8CqvC8+R0Sw74fqPed3ISZ1Lhx6Im0 Nmk2Lz9ziLt1J/8Ko50QJCSRguy8G+tjYs+PlIDoURs64/ZU3XXueaDRCPJyRoAsccdbbjr14t4vq IpOxBtdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruH9-00000006BfM-1RnJ; Mon, 16 Feb 2026 08:48:15 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vruH1-00000006BZd-3i9I for barebox@lists.infradead.org; Mon, 16 Feb 2026 08:48:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vruH0-0002Ix-A3; Mon, 16 Feb 2026 09:48:06 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vruGy-0012DF-2E; Mon, 16 Feb 2026 09:48:06 +0100 Received: from [::1] (helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vruGz-0000000Eudd-3v1E; Mon, 16 Feb 2026 09:48:05 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum , "Claude Opus 4.6" Date: Mon, 16 Feb 2026 09:44:04 +0100 Message-ID: <20260216084758.3548990-5-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216084758.3548990-1-a.fatoum@pengutronix.de> References: <20260216084758.3548990-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260216_004810_749960_8E48FD82 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE,SUBJECT_IN_BLACKLIST, SUBJECT_IN_BLOCKLIST autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master 04/39] efi: loader: fix pointer vs value comparison in free_efi_only X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The check 'nfreed >= 0' compares the pointer itself (which is always true for valid pointers) instead of the pointed-to value. This causes the freed counter to be incremented even after it has been set to -1 to indicate an error. Fix by dereferencing the pointer: '*nfreed >= 0'. Co-Authored-By: Claude Opus 4.6 Signed-off-by: Ahmad Fatoum --- efi/loader/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efi/loader/memory.c b/efi/loader/memory.c index 6ed7f76714f9..e8dfd59ee8ca 100644 --- a/efi/loader/memory.c +++ b/efi/loader/memory.c @@ -275,7 +275,7 @@ static int free_efi_only(struct resource *res, void *data) return false; } - if (nfreed >= 0) + if (*nfreed >= 0) ++*nfreed; return true; } -- 2.47.3