From: Ahmad Fatoum <a.fatoum@barebox.org>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: [PATCH 1/4] MAKEALL: early exit if config specified, but no arch
Date: Mon, 23 Feb 2026 12:31:32 +0100 [thread overview]
Message-ID: <20260223113446.638135-2-a.fatoum@barebox.org> (raw)
In-Reply-To: <20260223113446.638135-1-a.fatoum@barebox.org>
The behavior of MAKEALL to just build all configs and ignore the
specified config is confusing, so add a check guarding against this.
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
MAKEALL | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAKEALL b/MAKEALL
index 1e6d0c97b868..001b46a14726 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -461,6 +461,12 @@ else
echo "Skipping test due to failed build"
fi
else
+ if [ ! "${ARCH}" ]; then
+ echo "ARCH must be specified via the -a option or environment"
+ usage
+ exit 1
+ fi
+
do_build_defconfig ${ARCH} $config
fi
done
--
2.47.3
next prev parent reply other threads:[~2026-02-23 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:31 [PATCH 0/4] MAKEALL: sanity check command-line options more Ahmad Fatoum
2026-02-23 11:31 ` Ahmad Fatoum [this message]
2026-02-23 11:31 ` [PATCH 2/4] MAKEALL: devel mode: abort if no positional config Ahmad Fatoum
2026-02-23 11:31 ` [PATCH 3/4] MAKEALL: error out on options placed after the defconfig argument Ahmad Fatoum
2026-02-23 11:50 ` Sascha Hauer
2026-02-23 11:52 ` Ahmad Fatoum
2026-02-23 12:05 ` Sascha Hauer
2026-02-23 12:06 ` Ahmad Fatoum
2026-02-23 11:31 ` [PATCH 4/4] MAKEALL: flock build directory to prevent concurrent builds Ahmad Fatoum
2026-02-23 14:55 ` (subset) [PATCH 0/4] MAKEALL: sanity check command-line options more Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223113446.638135-2-a.fatoum@barebox.org \
--to=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox