mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/3] mci: treat unknown MMC version as greater than known versions
Date: Mon,  2 Mar 2026 17:37:41 +0100	[thread overview]
Message-ID: <20260302163748.577552-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20260302163748.577552-1-a.fatoum@pengutronix.de>

Currently, unknown MMC revisions are assumed to be v4.0-compatible.

Instead let's assume newer eMMC revisions to be compatible with the
newest that's explicitly supported by assigning 0xFFF as versions, so
comparison for being greater than some version always evaluate true.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/mci-core.c | 5 +++++
 include/mci.h          | 1 +
 2 files changed, 6 insertions(+)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 54006b149c0a..517e4de1c6b0 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1155,6 +1155,8 @@ static void mci_correct_version_from_ext_csd(struct mci *mci)
 {
 	if (!IS_SD(mci) && (mci->version >= MMC_VERSION_4) && mci->ext_csd) {
 		switch (mci->ext_csd[EXT_CSD_REV]) {
+		case 0:
+			mci->version = MMC_VERSION_4;
 		case 1:
 			mci->version = MMC_VERSION_4_1;
 			break;
@@ -1179,6 +1181,9 @@ static void mci_correct_version_from_ext_csd(struct mci *mci)
 		case 9:
 			mci->version = MMC_VERSION_5_1B;
 			break;
+		default:
+			mci->version = MMC_VERSION_MAX;
+			break;
 		}
 	}
 }
diff --git a/include/mci.h b/include/mci.h
index b05571730ec2..fc418ec0a2ea 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -47,6 +47,7 @@
 #define MMC_VERSION_5_0		(MMC_VERSION_MMC | 0x500)
 #define MMC_VERSION_5_1		(MMC_VERSION_MMC | 0x510)
 #define MMC_VERSION_5_1B	(MMC_VERSION_MMC | 0x51B)
+#define MMC_VERSION_MAX		(MMC_VERSION_MMC | 0xFFF)
 
 #define MMC_CAP_SPI			(1 << 0)
 #define MMC_CAP_4_BIT_DATA		(1 << 1)
-- 
2.47.3




  reply	other threads:[~2026-03-02 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 16:37 [PATCH 1/3] mci: add support for eMMC v5.1b Ahmad Fatoum
2026-03-02 16:37 ` Ahmad Fatoum [this message]
2026-03-02 16:37 ` [PATCH 3/3] mci: detect SD card v3 Ahmad Fatoum
2026-03-04  7:48 ` [PATCH 1/3] mci: add support for eMMC v5.1b Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302163748.577552-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox