From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Cc: "Claude Opus 4.6" <noreply@anthropic.com>
Subject: [PATCH v2 2/2] ARM: setup_c: avoid clearing BSS twice
Date: Wed, 04 Mar 2026 08:53:22 +0100 [thread overview]
Message-ID: <20260304-arm-setup-c-v2-2-d26af520ab03@pengutronix.de> (raw)
In-Reply-To: <20260304-arm-setup-c-v2-0-d26af520ab03@pengutronix.de>
Add a bss_cleared variable that is set after the first call to
setup_c(). On subsequent calls, the BSS clear is skipped to avoid
wiping already-initialized data.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/cpu/setupc_32.S | 15 +++++++++++++--
arch/arm/cpu/setupc_64.S | 14 ++++++++++++--
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/setupc_32.S b/arch/arm/cpu/setupc_32.S
index c2c3f97528..4a5e2f9e96 100644
--- a/arch/arm/cpu/setupc_32.S
+++ b/arch/arm/cpu/setupc_32.S
@@ -7,18 +7,29 @@
.section .text.setupc
/*
- * setup_c: clear bss
+ * setup_c: clear bss if not yet done
*/
ENTRY(setup_c)
mov r4, lr
+ ldr r0, =bss_cleared
+ ldr r1, [r0]
+ cmp r1, #0
+ bne 1f /* skip if already done */
ldr r0, =__bss_start
mov r1, #0
ldr r2, =__bss_stop
sub r2, r2, r0
bl __memset /* clear bss */
- ret r4
+ ldr r0, =bss_cleared
+ mov r1, #1
+ str r1, [r0] /* mark bss cleared */
+1: ret r4
ENDPROC(setup_c)
+.section .data
+bss_cleared:
+ .word 0
+
/*
* void relocate_to_adr(unsigned long targetadr)
*
diff --git a/arch/arm/cpu/setupc_64.S b/arch/arm/cpu/setupc_64.S
index fd95187a04..caa16d3582 100644
--- a/arch/arm/cpu/setupc_64.S
+++ b/arch/arm/cpu/setupc_64.S
@@ -7,19 +7,29 @@
.section .text.setupc
/*
- * setup_c: clear bss
+ * setup_c: clear bss if not yet done
*/
ENTRY(setup_c)
+ adr_l x0, bss_cleared
+ ldr w1, [x0]
+ cbnz w1, 1f /* skip if already done */
mov x15, x30
adr_l x0, __bss_start
mov x1, #0
adr_l x2, __bss_stop
sub x2, x2, x0
bl __memset /* clear bss */
+ adr_l x0, bss_cleared
+ mov w1, #1
+ str w1, [x0] /* mark bss cleared */
mov x30, x15
- ret
+1: ret
ENDPROC(setup_c)
+.section .data
+bss_cleared:
+ .word 0
+
/*
* void relocate_to_adr(unsigned long targetadr)
*
--
2.47.3
next prev parent reply other threads:[~2026-03-04 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 7:53 [PATCH v2 0/2] ARM: Avoid to clear bss multiple times Sascha Hauer
2026-03-04 7:53 ` [PATCH v2 1/2] ARM: setupc_32: remove relocation code from setup_c Sascha Hauer
2026-03-04 9:02 ` Ahmad Fatoum
2026-03-04 7:53 ` Sascha Hauer [this message]
2026-03-04 9:05 ` [PATCH v2 2/2] ARM: setup_c: avoid clearing BSS twice Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304-arm-setup-c-v2-2-d26af520ab03@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=noreply@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox