From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 04 Mar 2026 11:49:47 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxjnW-007xHX-35 for lore@lore.pengutronix.de; Wed, 04 Mar 2026 11:49:47 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vxjnX-0003WB-9c for lore@pengutronix.de; Wed, 04 Mar 2026 11:49:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Z//0KhqeYLTCagiqsQH97tfVeXqI0l8C6gIfG5uMXpA=; b=4Ykq8Ts4pgPux1dKrKw/0DAsP4 Wd9AO08770iRsxJbheDH9RxGcO+Z36vGKSoi5DseZiqED9g19IfmI622ZUfsj55sEsmUtD/cpGlFV vBvt42JwExd9HeTufuRLpdDn1j/W7eD49oOcoJ3NZ5raJYAcSfOaqWXIMEd+J6Bgmy3OrFLNIGgAm O0B1wgtdolcO5MNCXsuLlKcJNl15FmOMT4VGt/CJFTRFgbE6sWgRE2s/aT8Pz1FqXn/yT27YWFt7a dU7tVPNdE9p92fQ5ZTW+bcHpf1aE8UuPCvVuPsXTL/X6QsNKQc1yrdwC0U9X4Sm17vee+SloMpf0h zVRfDYXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxjmx-0000000H0q9-0rUC; Wed, 04 Mar 2026 10:49:11 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxjmu-0000000H0pL-0aXh for barebox@lists.infradead.org; Wed, 04 Mar 2026 10:49:09 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vxjms-0003P5-3K; Wed, 04 Mar 2026 11:49:06 +0100 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vxjmq-003hO7-1o; Wed, 04 Mar 2026 11:49:05 +0100 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1vxjmr-000000053jk-3JvX; Wed, 04 Mar 2026 11:49:05 +0100 From: Sascha Hauer To: Barebox List Date: Wed, 4 Mar 2026 11:49:04 +0100 Message-ID: <20260304104904.1205995-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260304_024908_176178_0D3001A1 X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Subject: [PATCH] pbl: console: fix undefined reference to vprintf() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) panic() now uses vprintf() which is not available without CONFIG_PBL_CONSOLE. Move the declaration to the right ifdeffery which already handles that case. Fixes: 33e3bc4782 ("pbl: fix panic() message printing") Signed-off-by: Sascha Hauer --- include/stdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/stdio.h b/include/stdio.h index 945ec46926..4c0dff0c00 100644 --- a/include/stdio.h +++ b/include/stdio.h @@ -12,10 +12,8 @@ /* stdin */ int tstc(void); int getchar(void); -int vprintf(const char *fmt, va_list args); #else static inline int tstc(void) { return 0; } -static inline int vprintf(const char *fmt, va_list args) { return 0; } static inline int getchar(void) { return -EINVAL; } #endif @@ -23,11 +21,13 @@ int readline(const char *prompt, char *buf, int len); #if (IN_PROPER && !defined(CONFIG_CONSOLE_NONE)) || \ (IN_PBL && defined(CONFIG_PBL_CONSOLE)) +int vprintf(const char *fmt, va_list args); static inline int puts(const char *s) { return console_puts(CONSOLE_STDOUT, s); } static inline void putchar(char c) { console_putc(CONSOLE_STDOUT, c); } #else static inline int puts(const char *s) { return 0; } static inline void putchar(char c) {} +static inline int vprintf(const char *fmt, va_list args) { return 0; } #endif int readline(const char *prompt, char *buf, int len); -- 2.47.3