mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Fabian Pflug <f.pflug@pengutronix.de>
To: barebox@lists.infradead.org
Cc: uol@pengutronix.de, Fabian Pflug <f.pflug@pengutronix.de>
Subject: [PATCH] i.MX: hab: write srk lock with hab command
Date: Fri,  6 Mar 2026 11:20:12 +0100	[thread overview]
Message-ID: <20260306102038.4065007-1-f.pflug@pengutronix.de> (raw)

The write_srk_hash functions already support the flag to write the SRK
lock, but it is never used in barebox. To prevent an attacker from
calculating an SRK hash that has the same bits set as the current SRK
hash, but with maybe more, we lock the SRK hash to prevent turning bits.

Writing the lock twice will probably result in unusable garbage and the
hab command itself already is written in a way to write the complete
hash and not parts of it.

Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
---
 commands/hab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/hab.c b/commands/hab.c
index 8ae943a4c8..b8ef770066 100644
--- a/commands/hab.c
+++ b/commands/hab.c
@@ -14,7 +14,7 @@ static int do_hab(int argc, char *argv[])
 {
 	int opt, ret, i;
 	char *srkhashfile = NULL, *srkhash = NULL;
-	unsigned flags = 0;
+	unsigned flags = IMX_SRK_HASH_WRITE_LOCK;
 	u8 srk[SRK_HASH_SIZE];
 	int lockdown = 0, info = 0;
 
-- 
2.47.3




             reply	other threads:[~2026-03-06 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 10:20 Fabian Pflug [this message]
2026-03-06 10:26 ` Marco Felsch
2026-03-06 10:36   ` Fabian Pflug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306102038.4065007-1-f.pflug@pengutronix.de \
    --to=f.pflug@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=uol@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox