mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 2/4] arm: socfpga: mailbox_s10: cleanup send command
Date: Wed, 11 Mar 2026 12:06:40 +0100	[thread overview]
Message-ID: <20260311-agilex5-qspi-v1-2-be8a8e1318e1@pengutronix.de> (raw)
In-Reply-To: <20260311-agilex5-qspi-v1-0-be8a8e1318e1@pengutronix.de>

The casts when passing the response buffer to mbox_send_cmd are useless,
because they already have the correct type.

Furthermore, setting an explicit buffer length is surprising and error
prone. Just use the array size of the response buffer as length.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/mach-socfpga/mailbox_s10.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-socfpga/mailbox_s10.c b/arch/arm/mach-socfpga/mailbox_s10.c
index f9ff6663dc38..f6aacd5551f2 100644
--- a/arch/arm/mach-socfpga/mailbox_s10.c
+++ b/arch/arm/mach-socfpga/mailbox_s10.c
@@ -297,8 +297,8 @@ int socfpga_mailbox_s10_qspi_close(void)
 int socfpga_mailbox_s10_qspi_open(void)
 {
 	int ret;
-	u32 resp_buf[1];
-	u32 resp_buf_len;
+	u32 resp_buf[1] = {};
+	u32 resp_buf_len = ARRAY_SIZE(resp_buf);
 	u32 reg;
 	u32 clk_khz;
 	int try = 0;
@@ -315,10 +315,8 @@ int socfpga_mailbox_s10_qspi_open(void)
 		return ret;
 
 	/* HPS will directly control the QSPI controller, no longer mailbox */
-	resp_buf_len = 1;
 	ret = mbox_send_cmd(MBOX_ID_BAREBOX, MBOX_QSPI_DIRECT, MBOX_CMD_DIRECT,
-			    0, NULL, 0, (u32 *)&resp_buf_len,
-			    (u32 *)&resp_buf);
+			    0, NULL, 0, &resp_buf_len, resp_buf);
 	if (ret)
 		goto error;
 

-- 
2.47.3




  parent reply	other threads:[~2026-03-11 11:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 11:06 [PATCH 0/4] arm: socfpga: mailbox_s10: cleanup and error handling Michael Tretter
2026-03-11 11:06 ` [PATCH 1/4] arm: socfpga: mailbox_s10: make retry logic more visible Michael Tretter
2026-03-11 11:06 ` Michael Tretter [this message]
2026-03-11 11:06 ` [PATCH 3/4] arm: socfpga: mailbox_s10: add error messages for QSPI Michael Tretter
2026-03-11 11:06 ` [PATCH 4/4] arm: socfpga: mailbox_s10: handle error 0x8f explicitly Michael Tretter
2026-03-13 14:39 ` [PATCH 0/4] arm: socfpga: mailbox_s10: cleanup and error handling Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311-agilex5-qspi-v1-2-be8a8e1318e1@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox