mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] fixup! firmware: Add compressed firmware symbols for PBL
Date: Thu, 19 Mar 2026 15:19:51 +0100	[thread overview]
Message-ID: <20260319141951.3942710-1-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20260316-compressed-firmware-v1-6-d9712142881e@pengutronix.de>

_fw_z_##name##_uncompressed_size is an absolute symbol, we must use its
address, not interpret as a memory location.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 include/firmware.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/firmware.h b/include/firmware.h
index 07651f1a93..6511d56b2e 100644
--- a/include/firmware.h
+++ b/include/firmware.h
@@ -127,7 +127,7 @@ int fwobj_uncompress(struct fwobj *fwobj, void *dest);
 	do {								\
 		extern char _fw_z_##name##_start[];			\
 		extern char _fw_z_##name##_end[];			\
-		extern unsigned long _fw_z_##name##_uncompressed_size;	\
+		extern char _fw_z_##name##_uncompressed_size[];		\
 		(fwobj)->data = _fw_z_##name##_start;			\
 		(fwobj)->size = _fw_z_##name##_end - _fw_z_##name##_start;\
 		(fwobj)->uncompressed_size =				\
-- 
2.47.3




  reply	other threads:[~2026-03-19 14:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 17:21 [PATCH 0/9] Firmware: support compressing firmware files Sascha Hauer
2026-03-16 17:21 ` [PATCH 1/9] ARM: socfpga: Drop unnecessary select USE_COMPRESSED_DTB Sascha Hauer
2026-03-16 17:21 ` [PATCH 2/9] ARM: radxa-rock5: Use compressed DTB Sascha Hauer
2026-03-16 17:21 ` [PATCH 3/9] ARM: Rockchip: Simplify retrieval of SoC specific addresses Sascha Hauer
2026-03-16 17:21 ` [PATCH 4/9] firmware: Move firmware assembly generation to scripts/gen-fw-s Sascha Hauer
2026-03-16 17:21 ` [PATCH 5/9] firmware: Use struct fwobj for get_builtin_firmware APIs Sascha Hauer
2026-03-16 17:21 ` [PATCH 6/9] firmware: Add compressed firmware symbols for PBL Sascha Hauer
2026-03-19 14:19   ` Sascha Hauer [this message]
2026-03-20  8:54   ` [PATCH] fixup! " Sascha Hauer
2026-03-16 17:21 ` [PATCH 7/9] firmware: Add fwobj_uncompress() for decompressing firmware in PBL Sascha Hauer
2026-03-16 17:21 ` [PATCH 8/9] ARM: Rockchip: Use compressed OP-TEE binary Sascha Hauer
2026-03-18  8:10   ` Sascha Hauer
2026-03-16 17:21 ` [PATCH 9/9] ARM: Rockchip: Use compressed TF-A binary Sascha Hauer
2026-03-19  6:53 ` [PATCH 0/9] Firmware: support compressing firmware files Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319141951.3942710-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox