* [PATCH] commands: bfetch: use 64-bit integer types for sizes
@ 2026-03-29 7:30 Ahmad Fatoum
0 siblings, 0 replies; only message in thread
From: Ahmad Fatoum @ 2026-03-29 7:30 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
size_human_readable() accepts a 64-bit argument (unsigned long long),
but we pass smaller types into it, leading to truncation when computing
the total sizes for display.
Switch to 64-bit variables to fix this.
Reported-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
---
commands/bfetch.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/commands/bfetch.c b/commands/bfetch.c
index d9c615f65aca..9dfb07aa2ab7 100644
--- a/commands/bfetch.c
+++ b/commands/bfetch.c
@@ -244,7 +244,7 @@ static struct bobject *print_cpu_mem_info(unsigned *line)
{
struct bobject *bret = NULL;
struct memory_bank *mem;
- unsigned long memsize = 0;
+ u64 memsize = 0;
int nbanks = 0;
int ret;
@@ -565,9 +565,9 @@ static void print_storage(unsigned *line)
unsigned nmtds = 0, nnvmem =0;
struct block_device *blk;
unsigned nblkdevs[BLK_TYPE_COUNT] = {};
- unsigned blkdev_sizes[BLK_TYPE_COUNT] = {};
+ u64 blkdev_sizes[BLK_TYPE_COUNT] = {};
struct mtd_info *mtd;
- size_t mtd_size = 0, nvmem_size = 0;
+ u64 mtd_size = 0, nvmem_size = 0;
struct string_list sl;
struct device *dev;
--
2.47.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-03-29 7:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-29 7:30 [PATCH] commands: bfetch: use 64-bit integer types for sizes Ahmad Fatoum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox