From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 02 Apr 2026 08:37:27 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8BgF-007krb-0d for lore@lore.pengutronix.de; Thu, 02 Apr 2026 08:37:27 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w8BgE-0007rq-K4 for lore@pengutronix.de; Thu, 02 Apr 2026 08:37:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To: References:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3is6XztqX4VcRb0WMBBrEJsu2+sy7IMpZkjHoxTOBJc=; b=oevpl/VyE4UEBf1BkOWcRQIpsR J+4+6DXXslOObwil8iULeVeI+6Rl/gL43TfQ55BIoa8kseGeYNj6800kjy84XasF3KsxArn6KjDF5 xdTUswIcs/rKOinyb5JJY1Y0OsbZ9VK2P/4RAn02YKeuvy83y0dgUWLk38e5UMRXLoqmyBOdmme5z ltD71TcJGd3WEJGOrHMfL5Utefq/RljsfHDv9poPBpGtBqgR1lhOtN03bnff8eLxf/vpNCqWR8jPp je9skIW/DaKhgOAA5mLcp+xeXckmmcbJhcP4K9nb7n34nJfQ804Ehm8/RmoMAiw/8bmib86KqNeny jsKv26Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w8Bfe-0000000Gu4I-2ubt; Thu, 02 Apr 2026 06:36:50 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w8BfZ-0000000Gu0F-1bd6 for barebox@lists.infradead.org; Thu, 02 Apr 2026 06:36:49 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w8BfX-0007On-BD; Thu, 02 Apr 2026 08:36:43 +0200 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w8BfW-003KcB-2g; Thu, 02 Apr 2026 08:36:42 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1w8BfW-00000003MbV-2rmo; Thu, 02 Apr 2026 08:36:42 +0200 From: Sascha Hauer Date: Thu, 02 Apr 2026 08:36:41 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260402-net-eth-do-udp-v1-2-af5d9fd6beec@pengutronix.de> References: <20260402-net-eth-do-udp-v1-0-af5d9fd6beec@pengutronix.de> In-Reply-To: <20260402-net-eth-do-udp-v1-0-af5d9fd6beec@pengutronix.de> To: BAREBOX X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775111802; l=1156; i=s.hauer@pengutronix.de; s=20230412; h=from:subject:message-id; bh=FQeRtKnPc8v2Yg6S496kOuY1sr+t6fxNsKMUeoiQxpg=; b=NKIso6Yl1XlICKGgMXJrOSF0fPe9u/QBtBIhHLhlIVS4pJy7WmobepGltKDFqofWSFweqGKZP /lMZuIBsPxkATp95GxKiZrQOzeR+ICm9TeUkKORqaGhNHWR3SibvA4H X-Developer-Key: i=s.hauer@pengutronix.de; a=ed25519; pk=4kuc9ocmECiBJKWxYgqyhtZOHj5AWi7+d0n/UjhkwTg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260401_233645_488478_D472DD21 X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Claude Opus 4.6" Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 02/10] fs: tftp: use net_eth_to_udp() for packet parsing X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Replace the separate net_eth_to_udp_payload(), net_eth_to_udphdr() and net_eth_to_udplen() calls with the new consolidated net_eth_to_udp() helper. This validates the packet length before accessing any headers and removes the need to cast away the unused len parameter. Signed-off-by: Sascha Hauer Co-Authored-By: Claude Opus 4.6 --- fs/tftp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/tftp.c b/fs/tftp.c index a454306b4b..fe6f42b073 100644 --- a/fs/tftp.c +++ b/fs/tftp.c @@ -628,11 +628,12 @@ static void tftp_recv(struct file_priv *priv, static void tftp_handler(void *ctx, char *packet, unsigned len) { struct file_priv *priv = ctx; - char *pkt = net_eth_to_udp_payload(packet); - struct udphdr *udp = net_eth_to_udphdr(packet); + struct net_udp_pkt udp; - (void)len; - tftp_recv(priv, pkt, net_eth_to_udplen(packet), udp->uh_sport); + if (net_eth_to_udp(packet, len, &udp)) + return; + + tftp_recv(priv, udp.payload, udp.len, udp.udp->uh_sport); } static int tftp_start_transfer(struct file_priv *priv) -- 2.47.3