mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: str@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change
Date: Wed, 13 May 2026 15:30:51 +0200	[thread overview]
Message-ID: <20260513133859.3877113-1-a.fatoum@pengutronix.de> (raw)

To align with Linux, mci_cmd was extended by a data pointer and the
send_cmd in barebox proper was adapted to drop the mci_data member.

The PBL drivers were not adapted and just ignore mci_data, except for
the Atmel MCI driver, which now discards the actually populated data and
passes cmd->data, which is always NULL.

Correct the argument to fix BOOT.BIN boot up on the KSZ9477-EVB.
A patch that switches pbl_mci as a whole to the new API will follow
separately.

Fixes: 28974435d085 ("mci: add data segment to mci_cmd")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/atmel_mci_pbl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/atmel_mci_pbl.c b/drivers/mci/atmel_mci_pbl.c
index ee8007fd0c4c..27727b27343c 100644
--- a/drivers/mci/atmel_mci_pbl.c
+++ b/drivers/mci/atmel_mci_pbl.c
@@ -12,7 +12,7 @@ static int pbl_atmci_common_request(struct pbl_mci *mci,
 				    struct mci_cmd *cmd,
 				    struct mci_data *data)
 {
-	return atmci_common_request(mci->priv, cmd, cmd->data);
+	return atmci_common_request(mci->priv, cmd, data);
 }
 
 static struct atmel_mci atmci_host;
-- 
2.47.3




             reply	other threads:[~2026-05-13 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 13:30 Ahmad Fatoum [this message]
2026-05-13 14:09 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513133859.3877113-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=str@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox