mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change
@ 2026-05-13 13:30 Ahmad Fatoum
  2026-05-13 14:09 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-05-13 13:30 UTC (permalink / raw)
  To: barebox; +Cc: str, Ahmad Fatoum

To align with Linux, mci_cmd was extended by a data pointer and the
send_cmd in barebox proper was adapted to drop the mci_data member.

The PBL drivers were not adapted and just ignore mci_data, except for
the Atmel MCI driver, which now discards the actually populated data and
passes cmd->data, which is always NULL.

Correct the argument to fix BOOT.BIN boot up on the KSZ9477-EVB.
A patch that switches pbl_mci as a whole to the new API will follow
separately.

Fixes: 28974435d085 ("mci: add data segment to mci_cmd")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/atmel_mci_pbl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/atmel_mci_pbl.c b/drivers/mci/atmel_mci_pbl.c
index ee8007fd0c4c..27727b27343c 100644
--- a/drivers/mci/atmel_mci_pbl.c
+++ b/drivers/mci/atmel_mci_pbl.c
@@ -12,7 +12,7 @@ static int pbl_atmci_common_request(struct pbl_mci *mci,
 				    struct mci_cmd *cmd,
 				    struct mci_data *data)
 {
-	return atmci_common_request(mci->priv, cmd, cmd->data);
+	return atmci_common_request(mci->priv, cmd, data);
 }
 
 static struct atmel_mci atmci_host;
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change
  2026-05-13 13:30 [PATCH master] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change Ahmad Fatoum
@ 2026-05-13 14:09 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-05-13 14:09 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: str


On Wed, 13 May 2026 15:30:51 +0200, Ahmad Fatoum wrote:
> To align with Linux, mci_cmd was extended by a data pointer and the
> send_cmd in barebox proper was adapted to drop the mci_data member.
> 
> The PBL drivers were not adapted and just ignore mci_data, except for
> the Atmel MCI driver, which now discards the actually populated data and
> passes cmd->data, which is always NULL.
> 
> [...]

Applied, thanks!

[1/1] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change
      https://git.pengutronix.de/cgit/barebox/commit/?id=26c3f0823a56 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-13 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-13 13:30 [PATCH master] mci: atmel_mci: fix mci_pbl breakage after mci_cmd::data change Ahmad Fatoum
2026-05-13 14:09 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox