mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: [PATCH 3/4] pci: add pci_is_bridge() helper
Date: Thu, 21 May 2026 10:36:57 +0200	[thread overview]
Message-ID: <20260521-pci-of-dynamic-v1-3-951f1878e378@pengutronix.de> (raw)
In-Reply-To: <20260521-pci-of-dynamic-v1-0-951f1878e378@pengutronix.de>

Mirror the Linux helper of the same name so callers don't have to
open-code the header-type compare.

Replace the open-coded site in pci_ea_init().

Assisted-by: Claude Opus 4.7
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/pci/pci.c   |  2 +-
 include/linux/pci.h | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 8d18889109..fc00ec2249 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -334,7 +334,7 @@ static void pci_ea_init(struct pci_dev *dev)
 	offset = ea + PCI_EA_FIRST_ENT;
 
 	/* Skip DWORD 2 for type 1 functions */
-	if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
+	if (pci_is_bridge(dev))
 		offset += 4;
 
 	/* parse each EA entry */
diff --git a/include/linux/pci.h b/include/linux/pci.h
index f6511e0095..a2dbaf6ec2 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -123,6 +123,20 @@ struct pci_dev {
 };
 #define	to_pci_dev(d) container_of(d, struct pci_dev, dev)
 
+/**
+ * pci_is_bridge - check if the PCI device is a bridge
+ * @dev: PCI device
+ *
+ * Return true if the PCI device is a bridge of PCI-to-PCI type. Masks the
+ * multi-function flag so a multi-function bridge is still recognised.
+ */
+static inline bool pci_is_bridge(struct pci_dev *dev)
+{
+	u8 type = dev->hdr_type & PCI_HEADER_TYPE_MASK;
+
+	return type == PCI_HEADER_TYPE_BRIDGE;
+}
+
 #define pci_resource_start(dev, bar)	((dev)->resource[(bar)].start)
 #define pci_resource_end(dev, bar)	((dev)->resource[(bar)].end)
 #define pci_resource_flags(dev, bar)	((dev)->resource[(bar)].flags)

-- 
2.47.3




  parent reply	other threads:[~2026-05-21  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  8:36 [PATCH 0/4] PCI: populate PCI host controller device nodes Sascha Hauer
2026-05-21  8:36 ` [PATCH 1/4] of: fall back to parent-prefixed encoding when address translation fails Sascha Hauer
2026-05-21  8:36 ` [PATCH 2/4] pci: fix DT node matching when reg encodes a non-zero bus number Sascha Hauer
2026-05-21  8:36 ` Sascha Hauer [this message]
2026-05-21 16:23   ` [PATCH 3/4] pci: add pci_is_bridge() helper Bjorn Helgaas
2026-05-21 19:46     ` Sascha Hauer
2026-05-21 20:53       ` Bjorn Helgaas
2026-05-21  8:36 ` [PATCH 4/4] pci: synthesize devicetree nodes for enumerated devices Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521-pci-of-dynamic-v1-3-951f1878e378@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox