From: Sascha Hauer <s.hauer@pengutronix.de>
To: BAREBOX <barebox@lists.infradead.org>
Subject: [PATCH 3/3] mci: sdhci: rockchip: Use generic sdhci_send_command()
Date: Thu, 21 May 2026 10:05:07 +0200 [thread overview]
Message-ID: <20260521-rockchip-emmc-fixes-v1-3-c91908ca1fb5@pengutronix.de> (raw)
In-Reply-To: <20260521-rockchip-emmc-fixes-v1-0-c91908ca1fb5@pengutronix.de>
We now have a generic sdhci_send_command() which exactly matches the
rockchip variant, so switch to the generic implementation.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/rockchip-dwcmshc-sdhci.c | 61 +-----------------------------------
1 file changed, 1 insertion(+), 60 deletions(-)
diff --git a/drivers/mci/rockchip-dwcmshc-sdhci.c b/drivers/mci/rockchip-dwcmshc-sdhci.c
index 1fdea7c4ab..0be5d9ff63 100644
--- a/drivers/mci/rockchip-dwcmshc-sdhci.c
+++ b/drivers/mci/rockchip-dwcmshc-sdhci.c
@@ -293,70 +293,11 @@ static void rk_sdhci_set_ios(struct mci_host *mci, struct mci_ios *ios)
sdhci_set_bus_width(&host->sdhci, ios->bus_width);
}
-static void print_error(struct rk_sdhci_host *host, int cmdidx)
-{
- dev_dbg(host->mci.hw_dev,
- "error while transfering data for command %d\n", cmdidx);
- dev_dbg(host->mci.hw_dev, "state = 0x%08x , interrupt = 0x%08x\n",
- sdhci_read32(&host->sdhci, SDHCI_PRESENT_STATE),
- sdhci_read32(&host->sdhci, SDHCI_INT_NORMAL_STATUS));
-}
-
static int rk_sdhci_send_cmd(struct mci_host *mci, struct mci_cmd *cmd)
{
struct rk_sdhci_host *host = to_rk_sdhci_host(mci);
- struct mci_data *data = cmd->data;
- u32 mask, command, xfer;
- int ret;
- dma_addr_t dma;
-
- ret = sdhci_wait_idle_data(&host->sdhci, cmd);
- if (ret)
- return ret;
-
- sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, ~0);
-
- mask = SDHCI_INT_CMD_COMPLETE;
- if (cmd->resp_type & MMC_RSP_BUSY)
- mask |= SDHCI_INT_XFER_COMPLETE;
-
- sdhci_write8(&host->sdhci, SDHCI_TIMEOUT_CONTROL, 0xe);
-
- sdhci_setup_data_dma(&host->sdhci, data, &dma);
-
- sdhci_set_cmd_xfer_mode(&host->sdhci, cmd, data,
- dma == SDHCI_NO_DMA ? false : true,
- &command, &xfer);
-
- sdhci_write16(&host->sdhci, SDHCI_TRANSFER_MODE, xfer);
-
- sdhci_write32(&host->sdhci, SDHCI_ARGUMENT, cmd->cmdarg);
- sdhci_write16(&host->sdhci, SDHCI_COMMAND, command);
-
- /* CMD19/21 generate _only_ Buffer Read Ready interrupt */
- if (mmc_op_tuning(cmd->cmdidx))
- mask = SDHCI_INT_DATA_AVAIL;
-
- ret = sdhci_wait_for_done(&host->sdhci, mask);
- if (ret) {
- sdhci_teardown_data(&host->sdhci, data, dma);
- goto error;
- }
-
- sdhci_read_response(&host->sdhci, cmd);
- sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, SDHCI_INT_CMD_COMPLETE);
-
- ret = sdhci_transfer_data_dma(&host->sdhci, cmd, data, dma);
-
-error:
- if (ret) {
- print_error(host, cmd->cmdidx);
- sdhci_reset(&host->sdhci, SDHCI_RESET_CMD);
- sdhci_reset(&host->sdhci, SDHCI_RESET_DATA);
- }
- sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, ~0);
- return ret;
+ return sdhci_send_command(&host->sdhci, cmd);
}
static int rk_sdhci_execute_tuning(struct mci_host *mci, u32 opcode)
--
2.47.3
prev parent reply other threads:[~2026-05-21 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 8:05 [PATCH 0/3] mci: sdhci Rockchip tuning fixes Sascha Hauer
2026-05-21 8:05 ` [PATCH 1/3] mci: rockchip-dwcmshc-sdhci: poll DATA_AVAIL for tuning commands Sascha Hauer
2026-05-21 8:05 ` [PATCH 2/3] mci: sdhci: Fix TIMEOUT_CONTROL register value Sascha Hauer
2026-05-21 8:05 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521-rockchip-emmc-fixes-v1-3-c91908ca1fb5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox