mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@arri.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: <barebox@lists.infradead.org>
Subject: Re: aiodev: imx7_adc driver
Date: Wed, 23 Aug 2023 18:30:13 +0200	[thread overview]
Message-ID: <2167506.irdbgypaU6@n95hx1g2> (raw)
In-Reply-To: <d33ac296-d6fd-6122-b8e2-0e0cfe2b09a7@pengutronix.de>

Hello Ahmad,

I forgot to mention that I still use barebox-2021.10. In this version,
regulator_get_voltage() returned an error code. After applying the missing
commit, I works find.

Maybe I could add the vf610_adc driver (works for i.MX6 series) to the 
upstream barebox later ...

regards,
Christian

On Wednesday, 23 August 2023, 18:25:05 CEST, Ahmad Fatoum wrote:
> Hello Christian,
> 
> On 23.08.23 17:05, Christian Eggers wrote:
> > Seems that I found the answer myself:
> > 
> > https://git.pengutronix.de/cgit/barebox/commit/?id=d353ffd5c6e6d4cee6eee72726125c965a0814f0
> 
> (y).
> 
> Did you run into any problems at runtime?
> 
> Cheers,
> Ahmad
> 
> > 
> > regards,
> > Christian
> > 
> > On Wednesday, 23 August 2023, 16:53:04 CEST, Christian Eggers wrote:
> >> Hi Ahmad,
> >>
> >> I am currently porting the vf610_adc driver from Linux to Barebox.
> >> Must thing can be done similar as for the imx7_adc driver.
> >>
> >> I have one question about the reference voltage:
> >>
> >> static int imx7d_adc_enable(struct imx7d_adc *info)
> >> {
> >> ...
> >> ret = regulator_get_voltage(info->vref);
> >> ...
> >> }
> >>
> >> What type of regulator do you use? I have declared a
> >> fixed regulator in my device tree:
> >>
> >> reg_adc_vref_3v3: regulator-3v3-adc {
> >> compatible = "regulator-fixed";
> >> regulator-name = "vref-3v3";
> >> regulator-min-microvolt = <3300000>;
> >> regulator-max-microvolt = <3300000>;
> >> };
> >>
> >> &adc2 {
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&pinctrl_adc2>;
> >> vref-supply = <&reg_adc_vref_3v3>;
> >> ...
> >> };
> >>
> >> But it looks like the fixed regulator driver in Barebox
> >> doesn't support reading the voltage (the Linux driver
> >> reports the value from "regulator-min-microvolt")?
> >>
> >> regards,
> >> Christian
> >>
> >>
> > 
> > 
> > 
> > 
> > _______________________________________________________​
> > Christian	 
> > 	Eggers
> > 
> > Software Engineer
> > ​
> > 
> > ARRI
> > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG 
> > 
> > Arriweg 17	, 
> > 	83071	 
> > 	Stephanskirchen
> > 
> > www.arri.com 
> > 
> > <http://www.arri.com/>
> > 	+49 8036 3009-3118 <tel:+49%208036%203009-3118>
> > 	
> > 	
> > 	CEggers@arri.de <mailto:CEggers@arri.de>
> > 
> > 
> > ​
> > 
> > CCM1 Camera Control Monitor <https://www.arri.com/en/camera-systems/cameras/ccm-1>
> > Get all the latest information from www.arri.com <https://www.arri.com/>, Facebook <https://www.facebook.com/TeamARRI>, Twitter <https://twitter.com/ARRIChannel>, Instagram <https://www.instagram.com/arri/>, LinkedIn <https://www.linkedin.com/company/arri> and YouTube <https://www.youtube.com/user/ARRIChannel>.
> > 
> > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> > Sitz: München ‑ Registergericht: Amtsgericht München ‑ Handelsregisternummer: HRA 57918
> > Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> > Sitz: München ‑ Registergericht: Amtsgericht München ‑ Handelsregisternummer: HRB 54477
> > Geschäftsführer: Dr. Matthias Erb (Chairman); Lars Weyer; Stephan Schenk; Walter Trauninger
> > 
> > ​
> > 
> 
> 







  reply	other threads:[~2023-08-23 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 14:53 Christian Eggers
2023-08-23 15:05 ` Christian Eggers
2023-08-23 16:25   ` Ahmad Fatoum
2023-08-23 16:30     ` Christian Eggers [this message]
2023-08-23 16:32       ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2167506.irdbgypaU6@n95hx1g2 \
    --to=ceggers@arri.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox