Re: [PATCH 2/2] ARM: cpu: common: define generic relocate_image

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 1/6/26 9:16 AM, Ahmad Fatoum wrote:
> -	__memset(dynsym, 0, (unsigned long)dynend - (unsigned long)dynsym);
> +	/* Optional: not required for correctness */
> +	if (dynend)
> +		__memset(dynsym, 0, (unsigned long)dynend - (unsigned long)dynsym);

Unexpected revelation: We don't have any R_ARM_ABS32 relocations any
longer. Maybe because ARM32 is now always relocatable?

This will allow us to simplify some things.

Cheers,
Ahmad

>  #else
>  #error "Architecture not specified"
>  #endif
> +}
> +
> +void __prereloc relocate_to_current_adr(void)
> +{
> +	relocate_image(get_runtime_offset(),
> +		       runtime_address(__rel_dyn_start),
> +		       runtime_address(__rel_dyn_end),
> +		       runtime_address(__dynsym_start),
> +		       runtime_address(__dynsym_end));
>  
>  	sync_caches_for_execution();
>  }
> @@ -196,4 +193,3 @@ void print_pbl_mem_layout(ulong membase, ulong endmem, ulong barebox_base)
>  	printf("membase               = 0x%08lx+0x%08lx\n",
>  	       membase, endmem - membase);
>  }
> -
> diff --git a/arch/arm/include/asm/reloc.h b/arch/arm/include/asm/reloc.h
> index 2d7411ab5284..62c07932fad4 100644
> --- a/arch/arm/include/asm/reloc.h
> +++ b/arch/arm/include/asm/reloc.h
> @@ -30,6 +30,9 @@ static inline __prereloc unsigned long global_variable_offset(void)
>  }
>  #define global_variable_offset() global_variable_offset()
>  
> +void relocate_image(unsigned long offset,
> +		    void *dstart, void *dend,
> +		    long *dynsym, long *dynend);
>  void relocate_to_current_adr(void);
>  void relocate_to_adr(unsigned long target);
>  void relocate_to_adr_full(unsigned long target);

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |