mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Oleksij Rempel <linux@rempel-privat.de>
To: Roland Hieber <r.hieber@pengutronix.de>,
	Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 2/2] fs/devfs: fix compile warnings
Date: Wed, 17 Oct 2018 11:44:54 +0200	[thread overview]
Message-ID: <2900c5d1-e614-d55e-69c8-6082aaf52132@rempel-privat.de> (raw)
In-Reply-To: <20181017092212.3rmxgfffxi3etxfe@pengutronix.de>

This is the list of all warnings:
common/ratp/ratp.c:75:22: warning: no previous prototype for
‘find_ratp_request’ [-Wmissing-prototypes]
fs/devfs.c:196:5: warning: no previous prototype for ‘devfs_iterate’
[-Wmissing-prototypes]
fs/fs.c:96:18: warning: no previous prototype for ‘mntget’
[-Wmissing-prototypes]
fs/fs.c:106:6: warning: no previous prototype for ‘mntput’
[-Wmissing-prototypes]
fs/fs.c:114:18: warning: no previous prototype for ‘lookup_mnt’
[-Wmissing-prototypes]
fs/fs.c:184:5: warning: no previous prototype for ‘create’
[-Wmissing-prototypes]
fs/fs.c:612:6: warning: no previous prototype for ‘dentry_kill’
[-Wmissing-prototypes]
fs/fs.c:625:5: warning: no previous prototype for
‘dentry_delete_subtree’ [-Wmissing-prototypes]
fs/fs.c:1115:16: warning: no previous prototype for ‘__d_alloc’
[-Wmissing-prototypes]
fs/fs.c:1155:16: warning: no previous prototype for ‘d_alloc’
[-Wmissing-prototypes]
fs/fs.c:1228:16: warning: no previous prototype for ‘d_lookup’
[-Wmissing-prototypes]
fs/fs.c:1244:6: warning: no previous prototype for ‘d_invalidate’
[-Wmissing-prototypes]
fs/fs.c:1321:6: warning: no previous prototype for ‘path_get’
[-Wmissing-prototypes]
fs/fs.c:1327:6: warning: no previous prototype for ‘path_put’
[-Wmissing-prototypes]
fs/fs.c:1510:5: warning: no previous prototype for ‘follow_up’
[-Wmissing-prototypes]
fs/fs.c:1702:18: warning: no previous prototype for ‘getname’
[-Wmissing-prototypes]
fs/fs.c:1721:6: warning: no previous prototype for ‘putname’
[-Wmissing-prototypes]
fs/fs.c:2068:5: warning: no previous prototype for ‘vfs_rmdir’
[-Wmissing-prototypes]
fs/fs.c:2092:5: warning: no previous prototype for ‘vfs_mkdir’
[-Wmissing-prototypes]
fs/fs.c:2351:5: warning: no previous prototype for ‘vfs_symlink’
[-Wmissing-prototypes]

Not sure if make sense to list all of them. Especially if you can see
from the patch diff, what the patch is doing.

Am 17.10.2018 um 11:22 schrieb Roland Hieber:
> For both of these, it would be nice to know what the compiler warnings
> were, in case anyone wants to grep the logs.
> 
>  - Roland
> 
> On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote:
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>>  fs/devfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/devfs.c b/fs/devfs.c
>> index d2b801036e..10f098280e 100644
>> --- a/fs/devfs.c
>> +++ b/fs/devfs.c
>> @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb)
>>  	return &node->inode;
>>  }
>>  
>> -int devfs_iterate(struct file *file, struct dir_context *ctx)
>> +static int devfs_iterate(struct file *file, struct dir_context *ctx)
>>  {
>>  	struct cdev *cdev;
>>  
>> -- 
>> 2.19.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
> 


-- 
Regards,
Oleksij

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-17  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 19:50 [PATCH v1 1/2] ratp: " Oleksij Rempel
2018-10-16 19:50 ` [PATCH v1 2/2] fs/devfs: " Oleksij Rempel
2018-10-17  9:22   ` Roland Hieber
2018-10-17  9:44     ` Oleksij Rempel [this message]
2018-10-17  9:55       ` Lucas Stach
2018-10-18  6:59 ` [PATCH v1 1/2] ratp: " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2900c5d1-e614-d55e-69c8-6082aaf52132@rempel-privat.de \
    --to=linux@rempel-privat.de \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    --cc=r.hieber@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox