From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 28 May 2025 18:28:57 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uKJeD-001FPd-2N for lore@lore.pengutronix.de; Wed, 28 May 2025 18:28:57 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uKJe7-0001pk-6X for lore@pengutronix.de; Wed, 28 May 2025 18:28:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s5TCmrb1f649QhLnTaD2og2QD9x2CSmpLoNdua/EPTo=; b=t2I3N/1GofrOCnMIUcXnSEEonf TLwORFk+rVvnbG2TtDvgPXl5JSZaKIbtfcdhASTlwDkqxKSbBfEyzMinclSqbBdjYdsjvjTdRl2vV Ogrb001Xddr7yt9gsoynhbvT4iRuTr5qma7WVMIOUtsPKEOYYoUQZGy5oUGiTuI9xMvExd902r4DO In/aosdhLRDrixCgbG7TmtOqj5eGsfJACjOdV9Xk60CeU8DaUnQYfC3jgxN/DGIQtLPo0uDALpA4s 3mbTbIWnoqwBgXfYm8jz4nERlbzxHV/CO6WG0ubkqPMenBuLUssjc8nd3NKrB7xbxzoNftRNMIGD/ O6wppaCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uKJdY-0000000Df70-2oWq; Wed, 28 May 2025 16:28:16 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uKIt7-0000000DZcL-1kgv for barebox@lists.infradead.org; Wed, 28 May 2025 15:40:18 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uKIt6-0007Zx-0w; Wed, 28 May 2025 17:40:16 +0200 Message-ID: <2bde04b0-5caa-4b06-aa00-fc7b24afb2dc@pengutronix.de> Date: Wed, 28 May 2025 17:40:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Marco Felsch , Ahmad Fatoum Cc: barebox@lists.infradead.org References: <20250528131411.935668-1-a.fatoum@barebox.org> <20250528131411.935668-2-a.fatoum@barebox.org> <20250528152431.db7nmbovzxkllf2u@pengutronix.de> Content-Language: en-US, de-DE, de-BE From: Ahmad Fatoum In-Reply-To: <20250528152431.db7nmbovzxkllf2u@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250528_084017_462493_C47E52F2 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/5] common: deep-probe: support specifying support in DT X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi, On 5/28/25 17:24, Marco Felsch wrote: > On 25-05-28, Ahmad Fatoum wrote: >> New boards should be deep probe enabled by default, which is currently >> done via board code. We want to support second stage boot on new boards >> without board code however, which means we need the possibility to make >> deep probe opt-out instead of opt-in. >> >> Signed-off-by: Ahmad Fatoum >> --- [snip] >> + /* deep probe requires resources to be described in DT */ >> + root = of_get_root_node(); >> + if (!root) >> + return false; > > if (!root) { > boardstate = DEEP_PROBE_NOT_SUPPORTED; No, the omission is intentional. I want to repeat the check for the root node on every call to avoid issues where this function is called once too early. >> - boardstate = DEEP_PROBE_NOT_SUPPORTED; >> - pr_info("not activated\n"); >> - return false; > > Can we please add a comment about the below if-else, e.g. referencing > the barebox,deep-probe.rst as well? Yes, will do for v2. Thanks for reviewing, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |