From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 23 Feb 2026 12:05:38 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuTkv-004nyh-20 for lore@lore.pengutronix.de; Mon, 23 Feb 2026 12:05:38 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vuTkv-0005EM-TJ for lore@pengutronix.de; Mon, 23 Feb 2026 12:05:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OZ6TzKBWyLtEBXvLQQLBgph2JOgFn8995nz65LXWcBg=; b=AELOZpxf6SdYaKq/1KDLLsSF1c bvUa/dQq2Yi9kWG79d88zpLyMnyTLb2E8difgp5ZBtmfmXisb0MRHythKBEltGduaPiruoD9a6rw3 DRa5OYUZascgwaSylbJdiRHw2QgVgYXP2vAF/qFK/xihfXryBdrhLJDEkGuXFmoYza66fdCxYgytb QkFBCz1gzzi2xugPBlj6Rj13a7w0cXjt54QPC3tr+tmajghi3T5s5vQLc/yIvpoSr8TtW7ORYJfZw rPQmxmu2qxSJZnvG3zjlxI7gfBhV6Dvwi124yl6Ps6euykM+7YTXAWfBsQvzmUoJKoZnFwbJM/rhs KsnGSwew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuTkZ-000000007e6-13Mj; Mon, 23 Feb 2026 11:05:15 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuTkW-000000007dc-1oUO for barebox@lists.infradead.org; Mon, 23 Feb 2026 11:05:13 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vuTkU-0005Ad-S4; Mon, 23 Feb 2026 12:05:10 +0100 Message-ID: <2f242d61-816b-4487-8551-d48e65b151c2@pengutronix.de> Date: Mon, 23 Feb 2026 12:05:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , Marco Felsch Cc: BAREBOX References: <20260212-vmaster-customers-leicageo-system1600-v2-0-f590b7d5b0e9@pengutronix.de> <20260212-vmaster-customers-leicageo-system1600-v2-5-f590b7d5b0e9@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260223_030512_655197_CD55B37B X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 5/7] commands: make run_command variadic X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 2/23/26 12:03 PM, Sascha Hauer wrote: > On Thu, Feb 12, 2026 at 11:02:07PM +0100, Marco Felsch wrote: >> This prepares run_command() to receive a format string and variadic >> arguments which can become quite handy for board code. It also ensures >> a proper cleanup for the command string and generalizes the error >> message printing. >> >> Signed-off-by: Marco Felsch >> --- >> common/hush.c | 23 ++++++++++++++++++++++- >> common/parser.c | 24 +++++++++++++++++++++++- >> include/command.h | 4 ++-- >> 3 files changed, 47 insertions(+), 4 deletions(-) >> >> diff --git a/common/hush.c b/common/hush.c >> index 2e0cc4229d3575dcf045f68ef8db3e943c41eedb..b46a42cc90c863376bb819755afc83271120200f 100644 >> --- a/common/hush.c >> +++ b/common/hush.c >> @@ -1922,7 +1922,7 @@ static char * make_string(char ** inp) >> return str; >> } >> >> -int run_command(const char *cmd) >> +static int __run_command(const char *cmd) >> { >> struct p_context ctx = {}; >> int ret; >> @@ -1938,6 +1938,27 @@ int run_command(const char *cmd) >> return ret; >> } >> >> +int run_command(const char *fmt, ...) >> +{ >> + va_list vargs; >> + char *cmd; >> + int error; >> + >> + va_start(vargs, fmt); >> + cmd = xvasprintf(fmt, vargs); >> + va_end(vargs); >> + >> + error = __run_command(cmd); >> + if (error) { >> + error_msg("Failed to run CMD: '%s' with %d\n", cmd, error); >> + free(cmd); >> + return error; >> + } > > Dropped this error printing while applying. There was no error printing > before this patch and also some commands might intentionally silently > fail, so error printing should be done in the caller. Good catch. gpio_get_value comes to mind where this would be rather confusing. Cheers, Ahmad > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |