mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Bastian Krause <bst@pengutronix.de>
To: Maik Otto <m.otto@phytec.de>, barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] i.mx6: signed boot: add habv4-imx6-gencsf.h to the flash header of the PHYTEC boards
Date: Tue, 4 Jun 2019 17:11:55 +0200	[thread overview]
Message-ID: <312ec99f-9b49-95a4-f2f0-4ebba41d0217@pengutronix.de> (raw)
In-Reply-To: <1558697578-69121-3-git-send-email-m.otto@phytec.de>

Hi,

On 5/24/19 1:32 PM, Maik Otto wrote:
> the habv4-imx6-gencsf.h is necessary in the board flash header to build
> a signed barebox
> 
> Signed-off-by: Maik Otto <m.otto@phytec.de>
> ---

Including the CSF template snippet for all boards breaks building
unsigned images, right?

A "#ifdef CONFIG_HAB .. #endif" in
arch/arm/mach-imx/include/mach/habv4-imx6-gencsf.h should fix this. To
keep things consistent this should be also included in
arch/arm/mach-imx/include/mach/habv3-imx25-gencsf.h.

Regards,
Bastian Krause

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-06-04 15:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 11:32 [PATCH 1/4] Makefile-imx: replace static variant to dynamic for signing images Maik Otto
2019-05-24 11:32 ` [PATCH 2/4] imx6, imx7, imx8: changing hardcoded suffix to variable Maik Otto
2019-05-24 11:32 ` [PATCH 3/4] i.mx6: signed boot: add habv4-imx6-gencsf.h to the flash header of the PHYTEC boards Maik Otto
2019-06-04 15:11   ` Bastian Krause [this message]
2019-05-24 11:32 ` [PATCH 4/4] imx6: added fit image signature to the devicetree for " Maik Otto
2019-05-24 12:55 ` [PATCH 1/4] Makefile-imx: replace static variant to dynamic for signing images Rouven Czerwinski
2019-05-27 13:08   ` Maik Otto
2019-05-28  6:36     ` Rouven Czerwinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=312ec99f-9b49-95a4-f2f0-4ebba41d0217@pengutronix.de \
    --to=bst@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.otto@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox