From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 05 May 2026 14:23:01 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wKEnl-001Eyf-2s for lore@lore.pengutronix.de; Tue, 05 May 2026 14:23:01 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wKEng-00017h-RO for lore@pengutronix.de; Tue, 05 May 2026 14:23:01 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=obQv4A0FZDtKZBUh4FAJSt8u+e6eVur3iONV8bKzRlA=; b=ty3++9YiO354lLALiqiK0nPEsA /zKNz0XkAwnN5KGUZUoCafnI80nZIHQOIWlM3f7yEG8dCi721MW2CgygyeiRXFdIqnx4ZsNRj+oki pUS74TJ0vYHC5fkoZ05mRjsoQPrKYQY3f518dDNZ6kALM8KKqklubdI+/BWVavuKPAo04NnXxpCSV WKE5EGSS8OILE/KAv2qEJeY2TdQRBmtpkOlLe8X2sC1Qy8vVYQY4QWRqchWf7Dc4LRbel+QSgR1xi EmnihDZvhh3k1QC5ujhtJIwqhxmZXkyUMj85klf0pDcDv7aLEdF4rqZjwfHOpMQE36X2bBThzfMhn F9TnGweg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKEn3-0000000GA7E-0Ju9; Tue, 05 May 2026 12:22:17 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wKEn0-0000000GA6Z-0h6K for barebox@lists.infradead.org; Tue, 05 May 2026 12:22:15 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wKEmw-0000oS-Mp; Tue, 05 May 2026 14:22:10 +0200 Message-ID: <32447f15-ff62-4215-a845-376f28261b87@pengutronix.de> Date: Tue, 5 May 2026 14:22:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Alexander Shiyan Cc: barebox@lists.infradead.org References: <20260428132811.3691086-1-eagle.alexander923@gmail.com> <4e34c9f9-816a-4242-a324-0f23505e9cc8@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260505_052214_227147_29FA2F64 X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 1/2] Add support for extlinux.conf X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Alexander, On 5/5/26 2:19 PM, Alexander Shiyan wrote: > barebox@Diasom DS-RK3568-SOM-EVB:/ global > * bootm.~appendroot: true This should be bootm.appendroot: 1. > bootm.~appendroot: true, but now is ever not added to the cmdline. The tilde is just an implementation detail in common/bootm.c. You should just global.bootm.appendroot as before. Thanks, Ahmad > > вт, 5 мая 2026 г. в 13:49, Ahmad Fatoum : >> >> Hello Alexander, >> >> On 5/5/26 12:47 PM, Alexander Shiyan wrote: >>> Hello Ahmad. >>> >>> ... >>>>> + if (e->append) { >>>>> + char *append; >>>>> + >>>>> + /* >>>>> + * The same rootfs image may be launched from eMMC or SD card. >>>>> + * Remove any hardcoded root= parameter from "append" to avoid >>>>> + * conflicts, then let barebox automatically add the correct >>>>> + * root= (via global.bootm.appendroot) based on the boot device. >>>>> + */ >>>>> + if (data.appendroot) >>>>> + append = remove_param(e->append, "ROOT="); >>> ... >>>> I thus have a question to you: What happens if you drop remove_param() >>>> completely? Sure we will have two root=, but the later gets precedence, >>>> so your use case would continue to work without giving users a wrong >>>> expectation. >>> >>> Yes, the second one takes priority. >>> The second one is the one added via extlinux.conf APPEND option. >>> In our case we need the first parameter, i.e. which comes from barebox >>> when global.bootm.appendroot is toggled on. >> >> Ack. Please check the series I Cc'd you on, which ensures that >> global.bootm.appendroot applies _after_ extlinux.conf APPEND. >> >> Thanks, >> Ahmad >> >>> >>> Thanks! >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |