mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Teresa Remmet <t.remmet@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver
Date: Tue, 12 Feb 2019 14:23:04 +0100	[thread overview]
Message-ID: <33609c0d6dc1627d573a659c9957c175b0d0fcf2.camel@phytec.de> (raw)
In-Reply-To: <20190212080906.5bgldri5gjpjptys@pengutronix.de>

Hello Sascha and Sam, 
 
Am Dienstag, den 12.02.2019, 09:09 +0100 schrieb Sascha Hauer:
> Hi Sam,
> 
> On Mon, Feb 11, 2019 at 04:41:38PM +0100, Sam Ravnborg wrote:
> > Hi Teresa.
> > 
> > On Mon, Feb 11, 2019 at 04:16:34PM +0100, Teresa Remmet wrote:
> > > Adds minimal support for the sysc interconnect target module
> > > found
> > > on many TI SoCs. With this device tree includes have been
> > > rearagned.
> > 
> > s/rearagned/rearranged"
> > 
> > > We need the driver to probe the child devices of the bus.
> > > 
> > > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > 
> > The implementation is simple, which is always a good thing.
> > There is so far nothing TI specific in the implementation except
> > for the of_device_id entries.
> > Would it be an idea to rename this to a simple-bus driver.
> > And then we can add relevant ID's as other may need the same
> > functionality.
> > ?
> 
> I'm not sure if it's worth it. It could also happen that we'll need
> to do
> some TI specific initialization in the currently not-so-generic
> driver
> in which case we would have to fork from the generic driver later.

Yes there might be some special initialization added later. That's what
I thought, too. At the moment the child devices of a simple bus are
populated in of_probe(). 
If there is any need for a such a generic driver right now. I will
rename it.

Teresa

> 
> I'm fine with either way.
> 
> Sascha
> 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-02-12 13:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 15:16 [PATCH 0/7] " Teresa Remmet
2019-02-11 15:16 ` [PATCH 1/7] drivers: bus: " Teresa Remmet
2019-02-11 15:41   ` Sam Ravnborg
2019-02-12  8:09     ` Sascha Hauer
2019-02-12 13:23       ` Teresa Remmet [this message]
2019-02-12 16:32         ` Sam Ravnborg
2019-02-12  2:57   ` Andrey Smirnov
2019-02-12 13:13     ` Teresa Remmet
2019-02-13  0:56       ` Andrey Smirnov
2019-02-13  8:19         ` Teresa Remmet
2019-02-12  8:10   ` Sascha Hauer
2019-02-12 13:25     ` Teresa Remmet
2019-02-11 15:16 ` [PATCH 2/7] arm: configs: omap_defconfig: Enable " Teresa Remmet
2019-02-11 15:16 ` [PATCH 3/7] arm: configs: am33xx_mlo_defconfig: " Teresa Remmet
2019-02-11 15:16 ` [PATCH 4/7] drivers: of: Add function to enable and register a device by alias Teresa Remmet
2019-02-11 15:16 ` [PATCH 5/7] arm: mach-omap: am335x_generic: Enable nodes by alias where needed Teresa Remmet
2019-02-11 15:16 ` [PATCH 6/7] net: ethernet: cpsw: cpsw-phy-sel: Use phandle for phy sel Teresa Remmet
2019-02-11 15:16 ` [PATCH 7/7] arm: dts: am335x-phytec: Use phy-handle instead of phy_id Teresa Remmet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33609c0d6dc1627d573a659c9957c175b0d0fcf2.camel@phytec.de \
    --to=t.remmet@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox