Re: [PATCH 0/7 v2] digest: allow multiple implementation of digest

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

> On Mar 25, 2015, at 6:26 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> On Tue, Mar 24, 2015 at 02:00:35PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>> Hi,
>> 
>> 	The following serie allow you to have multiple driver for
>> 	the digest.
>> 
>> 	This also switch the sha1 implementation to the kernel one and
>> 	add the armv4 asm implementtion that save nearly 6KiB in a zbarebox
>> 	lzo.
>> 
>> 
>> v2:
>> 	switch sha256 and sha512 to linux implementation
>> 	add arm sha256 asm implementation
>> 
>> The following changes since commit 52d4a0321405b7525422f04fffbe7f318c9c5a88:
>> 
>>  Merge branch 'for-next/state' into next (2015-03-19 07:55:59 +0100)
>> 
>> are available in the git repository at:
>> 
>>  git://git.jcrosoft.org/barebox.git delivery/sha1
>> 
>> for you to fetch changes up to 6bebe62f4b828f0b85334b8a8a189e8a84864935:
>> 
>>  arm: crypto: add sha256 assembly support (2015-03-24 17:18:55 +0800)
> 
> Except for the one comment I made the series looks fine.

I found a bug in the sha256 asm code we discuss it on the arm ML with a fix
I’ll integrate it

and I found an other bug that the hmac will register multiple instance of itself
for each shaxxx algo, but will always use the best shaxxx at runtime

So it’ll send a v3 for those fix

Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox