From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 06 Feb 2026 13:06:47 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1voKbo-009TPJ-0V for lore@lore.pengutronix.de; Fri, 06 Feb 2026 13:06:47 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1voKbn-00037F-27 for lore@pengutronix.de; Fri, 06 Feb 2026 13:06:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qrmx/h4XHsymbS8InyASga6tmizb6C7T7HV23qfdBcg=; b=gc3DOU/XehO5xTejT4j5iStBUI o9PYK8cMYXDDRXgXrQ+ZXtOkPFhnJK4Nb4FROM6HQnKvOADXDE3SjvIkkcd1sd800qAAMQUPoS0nZ 8ROu3ov5qGur3R+GraBIv5T2plqj6DtORBGPmFVMZeaqaZhkHtnbPTheW33C/8YozL1JEjXC5d2Y2 01wOx9XYJagW/ukM+MSRZwXIE6nebhHLxgY8Rb2igOWlXs0vqSNsOEkv8I1va4g4vNowy4rsesBLw qAXuEeiKcRVPsi1QCXkj+9CyEgApXmrKiLHzVdD5HHyFRLx5Wlfmfg9YjCokY8/XzEGDbRmkYhPAn 97z/iBWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1voKbA-0000000BHQU-3XO3; Fri, 06 Feb 2026 12:06:08 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1voKb7-0000000BHPn-0Vlq for barebox@lists.infradead.org; Fri, 06 Feb 2026 12:06:07 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1voKau-0002zG-Qs; Fri, 06 Feb 2026 13:05:52 +0100 Message-ID: <388370f2-c08a-4394-988f-d4686db50884@pengutronix.de> Date: Fri, 6 Feb 2026 13:05:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Marco Felsch , Sascha Hauer , BAREBOX References: <20260204-v2025-09-0-topic-optee-of-handling-v2-0-da075e6818e0@pengutronix.de> <20260204-v2025-09-0-topic-optee-of-handling-v2-14-da075e6818e0@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: <20260204-v2025-09-0-topic-optee-of-handling-v2-14-da075e6818e0@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260206_040605_190480_600BB41A X-CRM114-Status: GOOD ( 24.76 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 14/15] of: base: register optional OP-TEE overlay X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 2/4/26 9:01 PM, Marco Felsch wrote: > The BL32 OP-TEE binary can provide an overlay which contains all > required configurations made by the secure-os, e.g. reserved-memory > nodes, the firmware-interface (smc) and so on. > > This overlay can be used to uniform the OP-TEE configuration handling > for all OF platforms. While this patch is platform agnostic, the OP-TEE > overlay handling still depends on platform and machine specific > integrations. > > The previous patches added the required platform support for all > i.MX8MM/N/P SoCs, but each i.MX8MM/N/P machine need add the machine > support by itself. > > Allthough only i.MX8MM/N/P platform support was added, this commit > prepare all ARMv8 platforms for the new overlay mechanism. Why is this ARMv8-specific? Seems to me it applies to all architectures now even? (provided they have OPTEE support) > > Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum > --- > arch/arm/mach-imx/imx9.c | 2 +- > arch/arm/mach-rockchip/rockchip.c | 3 ++- > drivers/of/base.c | 3 +++ > drivers/soc/imx/soc-imx8m.c | 3 ++- > 4 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-imx/imx9.c b/arch/arm/mach-imx/imx9.c > index 25ba7e444843ea5ae817dd8103074e5a50fb48f0..ada4048d4ca07b5a2f8a5ee5ceb3e3b3ecb24af8 100644 > --- a/arch/arm/mach-imx/imx9.c > +++ b/arch/arm/mach-imx/imx9.c > @@ -174,7 +174,7 @@ int imx93_init(void) > imx93_set_arm_clock(); > imx93_bootsource(); > > - if (IS_ENABLED(CONFIG_PBL_OPTEE)) { > + if (IS_ENABLED(CONFIG_PBL_OPTEE) && !optee_overlay_registered()) { > static struct of_optee_fixup_data optee_fixup_data = { > .shm_size = OPTEE_SHM_SIZE, > .method = "smc", > diff --git a/arch/arm/mach-rockchip/rockchip.c b/arch/arm/mach-rockchip/rockchip.c > index 0828f0fa72a9ad2495e012a42918c4b5431652e7..6ed7802cc695a61253c937b24f5b1c2a1eea7732 100644 > --- a/arch/arm/mach-rockchip/rockchip.c > +++ b/arch/arm/mach-rockchip/rockchip.c > @@ -33,7 +33,8 @@ static int rockchip_init(void) > { > const struct optee_header *hdr = rk_scratch_get_optee_hdr(); > > - if (IS_ENABLED(CONFIG_PBL_OPTEE) && optee_verify_header(hdr) == 0) { > + if (IS_ENABLED(CONFIG_PBL_OPTEE) && !optee_overlay_registered() && > + optee_verify_header(hdr) == 0) { > static struct of_optee_fixup_data optee_fixup_data = { > .shm_size = OPTEE_SHM_SIZE, > .method = "smc", > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 54fd458bd9a1e38e665768d911934960358b42a9..3110f377212b272ae09bb15b20803b718c734f32 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > > static struct device_node *root_node; > > @@ -2133,6 +2134,8 @@ int barebox_register_fdt(const void *dtb) > return PTR_ERR(root); > } > > + optee_register_overlay(); > + > return barebox_register_of(root); > } > > diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c > index 3b83284fcbfd56d543cc300b8d42771202aa0bbb..695fc3b027ae81cc8c83cbf27aff261c0459aa8a 100644 > --- a/drivers/soc/imx/soc-imx8m.c > +++ b/drivers/soc/imx/soc-imx8m.c > @@ -207,7 +207,8 @@ static int imx8_soc_imx8m_init(struct soc_device_attribute *soc_dev_attr) > imx_set_reset_reason(src + IMX7_SRC_SRSR, imx7_reset_reasons); > pr_info("%s unique ID: %s\n", cputypestr, uid); > > - if (IS_ENABLED(CONFIG_PBL_OPTEE) && imx8m_tzc380_is_enabled()) { > + if (IS_ENABLED(CONFIG_PBL_OPTEE) && imx8m_tzc380_is_enabled() && > + !optee_overlay_registered()) { > static struct of_optee_fixup_data optee_fixup_data = { > .shm_size = OPTEE_SHM_SIZE, > .method = "smc", > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |