From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 10 Apr 2026 10:14:19 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wB70N-00Aa9J-02 for lore@lore.pengutronix.de; Fri, 10 Apr 2026 10:14:19 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wB70M-000703-BE for lore@pengutronix.de; Fri, 10 Apr 2026 10:14:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kB2+EA3vgvUV02M7IRQSaSCrLizL/XJJ5atBFqED82U=; b=iA2tTsBFadflNd4RPlsv5S1qbz P9ZdzTWOKdceNbZ8HaaSyDGgr/lX+KGc86mcB6IQGKRPjAFpg7dK8fUAmgyDbT1ZuEaT5pyhY8IFd xVbGdWMhwyozu5MzgFMUGejNBWonOBMGxt5FWKKvCJet5O7qyj3zBfRVZ+x5XuLWMqIpWFIKAqNQE k4fDSEjYyMHk6jDULadiZYz3dc6Rk3ttFiKMCFum+0wB74zQQTg1Awa1u3jbnn3ch6whCaBhZgwNJ 3K1qKFO/BupXjCjje2yvNUJJFQVQlka6ALiHcMJ5H5Ij3vWDBIw8BsyjxYsZNH0Tvyj27N70LE8H6 iihag+6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wB6zq-0000000Bowu-0fvx; Fri, 10 Apr 2026 08:13:46 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wB6zn-0000000BowA-3xzQ for barebox@lists.infradead.org; Fri, 10 Apr 2026 08:13:45 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wB6zl-0006tF-Ls; Fri, 10 Apr 2026 10:13:41 +0200 Message-ID: <39a08f69-3461-48da-a890-0e3b879bb40a@pengutronix.de> Date: Fri, 10 Apr 2026 10:13:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Michael Tretter , Sascha Hauer , BAREBOX Cc: Steffen Trumtrar References: <20260409-socfpga-iossm-v1-v2-0-09effab91bc1@pengutronix.de> <20260409-socfpga-iossm-v1-v2-4-09effab91bc1@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: <20260409-socfpga-iossm-v1-v2-4-09effab91bc1@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260410_011343_993761_63F4F416 X-CRM114-Status: GOOD ( 23.90 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 04/10] arm: socfpga: iossm: store size in bytes X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello, On 4/9/26 3:52 PM, Michael Tretter wrote: > The mem_width_info is the memory size in gigabits. Convert it to bytes > before storing it for each bank to have a more convenient format and > simplify the conversion when reading the value. > > Signed-off-by: Michael Tretter > --- > Changes in v2: > > - Change memory_size in io96b_mb_ctrl to phys_size_t to prevent overflow Thanks for addressing the concern. I looked it over and there's still a chance for overflow. > diff --git a/arch/arm/mach-socfpga/iossm_mailbox.c b/arch/arm/mach-socfpga/iossm_mailbox.c > index 9299fee71e0b..042ea4a99e5c 100644 > --- a/arch/arm/mach-socfpga/iossm_mailbox.c > +++ b/arch/arm/mach-socfpga/iossm_mailbox.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include "iossm_mailbox.h" > #include > #include > @@ -404,21 +405,25 @@ int io96b_get_mem_width_info(struct io96b_info *io96b_ctrl) > struct io96b_mb_resp usr_resp; > struct io96b_mb_ctrl *mb_ctrl; > int i, j; > - u16 memory_size; > - u16 total_memory_size = 0; > + phys_size_t memory_size; > + u32 mem_width_info; > + phys_size_t total_memory_size = 0; > > /* Get all memory interface(s) total memory size on all instance(s) */ > for (i = 0; i < io96b_ctrl->num_instance; i++) { > mb_ctrl = &io96b_ctrl->io96b[i].mb_ctrl; > memory_size = 0; > + > for (j = 0; j < mb_ctrl->num_mem_interface; j++) { > io96b_mb_req_no_param(io96b_ctrl->io96b[i].io96b_csr_addr, > mb_ctrl->ip_type[j], > mb_ctrl->ip_instance_id[j], > CMD_GET_MEM_INFO, GET_MEM_WIDTH_INFO, &usr_resp); > + mem_width_info = usr_resp.cmd_resp_data[1] & GENMASK(7, 0); I assume this is the RAM memory width in bytes, e.g. 2 or 4 bytes, but the mask allows it to be up to 255. > > - memory_size = memory_size + > - (usr_resp.cmd_resp_data[1] & GENMASK(7, 0)); > + mb_ctrl->memory_size[j] = mem_width_info * (SZ_1G / SZ_8); SZ_4G / (SZ_1G / 8) = 32 So the maximum value permitted in mem_width_info without overflowing is 31, but the code accepts up to 255. As all types on the left hand side are 32-bit only. Worth a check or adaptation of the mask? Cheers, Ahmad > + > + memory_size += mb_ctrl->memory_size[j]; > } > > if (!memory_size) { > diff --git a/arch/arm/mach-socfpga/iossm_mailbox.h b/arch/arm/mach-socfpga/iossm_mailbox.h > index bd66621d5f70..0c15c92bb867 100644 > --- a/arch/arm/mach-socfpga/iossm_mailbox.h > +++ b/arch/arm/mach-socfpga/iossm_mailbox.h > @@ -79,6 +79,7 @@ struct io96b_mb_ctrl { > u32 num_mem_interface; > u32 ip_type[2]; > u32 ip_instance_id[2]; > + phys_size_t memory_size[2]; > }; > > /* > @@ -101,7 +102,7 @@ struct io96b_mb_resp { > * @mb_ctrl: IOSSM mailbox required information > */ > struct io96b_instance { > - u16 size; > + phys_size_t size; > phys_addr_t io96b_csr_addr; > bool cal_status; > struct io96b_mb_ctrl mb_ctrl; > @@ -126,7 +127,7 @@ struct io96b_info { > bool overall_cal_status; > const char *ddr_type; > bool ecc_status; > - u16 overall_size; > + phys_size_t overall_size; > struct io96b_instance io96b[MAX_IO96B_SUPPORTED]; > bool ckgen_lock; > u8 num_port; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |