Re: [PATCH 1/4] Makefile-imx: replace static variant to dynamic for signing images

[Maik Otto <m.otto@phytec.de>]

Hi Mr. Czerwinski,

i will change the patches and make checkboxes for the different images.
my idea is to use different file extensions for the images
for example
.img    for normal
.simg    for signed
.esimg    for encrypted signed
.usimg     for usb signed

the other idea is to use different filenames for the images.
for example
-s.img
-es.img
-us.img

my favorite is to use different file extensions for the images, but im
not shure is this ok or can this have other negative effects.
so the standard extension is .img
What do you think about the file name or file extension?

best regards
Maik Otto

Am 24.05.2019 um 14:55 schrieb Rouven Czerwinski:
> Hi,
>
> comments as always below.
>
> On Fri, 2019-05-24 at 13:32 +0200, Maik Otto wrote:
>> Insert in the Kconfig the selection for the build type signed, usb
>> signed,
>> encrypted/signed and  unsigned as basic for the replacement the
>> static
>> variant in the Makefile.imx
>>
>> Signed-off-by: Maik Otto <m.otto@phytec.de>
>> ---
>>  arch/arm/mach-imx/Kconfig | 25 +++++++++++++++++++++++++
>>  images/Makefile.imx       |  1 +
>>  2 files changed, 26 insertions(+)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index 71d37ce..fdb4239 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -845,6 +845,24 @@ config HABV4_IMG_CRT_PEM
>>  
>>  endif
>>  
>> +if HABV4
>> +
>> +choice
>> +	prompt "Select Building Signed/Encrypted Bootloader"
>> +
>> +config HABV4_IMAGE_SIGNED
>> +	bool "build signed images"
>> +
>> +config HABV4_IMAGE_SIGNED_USB
>> +	bool "build signed images and signed USB images"
>> +
>> +config HABV4_IMAGE_SIGNED_ENCRYPTED
>> +	bool "build signed encrypted images"
>> +
>> +endchoice
>> +
>> +endif
> This is a regression in contrast with the current system. The current
> systems allows a build of all three images (albeit with a modification
> to Makefile.imx), and imo this should be a selection rather than a
> choice.
>
> Regards,
> Rouven Czerwinski



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox