From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Maxim Kochetkov <fido_max@inbox.ru>, barebox@lists.infradead.org
Cc: pmamonov@gmail.com, a.kuyan@yadro.com, p.mamonov@yadro.com,
Maxim Kochetkov <m.kochetkov@yadro.com>
Subject: Re: [PATCH 1/1] serial: ns16550: move iomem/ioport init after clock init
Date: Fri, 17 Feb 2023 10:02:42 +0100 [thread overview]
Message-ID: <4073a83d-e7b8-0965-b44b-ad1005b800c7@pengutronix.de> (raw)
In-Reply-To: <20230217073157.21573-1-fido_max@inbox.ru>
Hello Maxim,
On 17.02.23 08:31, Maxim Kochetkov wrote:
> - ret = ns16550_init_iomem(dev, priv);
> - if (ret)
> - ret = ns16550_init_ioport(dev, priv);
> -
> if (ret)
> return ret;
ret is now uninitialized here.
>
> @@ -511,6 +507,10 @@ static int ns16550_probe(struct device *dev)
> goto err;
> }
>
> + ret = ns16550_init_iomem(dev, priv);
> + if (ret)
> + ret = ns16550_init_ioport(dev, priv);
second ret is never checked.
If you move the second if (ret), patch looks ok to me.
jfyi, If you enable deep probe for your board/platform, clk_get()
would automatically probe the clock driver if unavailable, so you
shouldn't ever see -EPROBE_DEFER.
Cheers,
Ahmad
> +
> cdev = &priv->cdev;
> cdev->dev = dev;
> cdev->tstc = ns16550_tstc;
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-02-17 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:31 Maxim Kochetkov
2023-02-17 9:02 ` Ahmad Fatoum [this message]
2023-02-17 14:03 ` Maxim Kochetkov
2023-02-17 14:10 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4073a83d-e7b8-0965-b44b-ad1005b800c7@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=a.kuyan@yadro.com \
--cc=barebox@lists.infradead.org \
--cc=fido_max@inbox.ru \
--cc=m.kochetkov@yadro.com \
--cc=p.mamonov@yadro.com \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox