Re: [PATCH 07/13] video: Add Sitronix st7789v panel driver

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sascha,

On 26.09.24 15:15, Sascha Hauer wrote:
> +	ret = st7789v_read_data(ctx, MIPI_DCS_GET_DISPLAY_ID, ids, ST7789V_IDS_SIZE);
> +	if (ret)
> +		return ret;
> +printf("%s: %02x %02x %02x\n", __func__, ids[0], ids[1], ids[2]);

Debugging left-over.

> +static int st7789v_prepare(struct st7789v *ctx)
> +{


> +	ret = regulator_enable(ctx->power);
> +	if (ret)
> +		return ret;
> +
> +	gpiod_set_value(ctx->reset, 1);
> +	mdelay(30);
> +	gpiod_set_value(ctx->reset, 0);
> +	mdelay(120);

Ouch. That's quite a bit of wasted time. Could it make sense to move device
out of reset in probe function instead?

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |