From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 26 Sep 2024 16:16:51 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1stpIY-00321w-0O for lore@lore.pengutronix.de; Thu, 26 Sep 2024 16:16:51 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stpIY-00070k-LE for lore@pengutronix.de; Thu, 26 Sep 2024 16:16:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iT9FIV8MO1AY0u+d1umlU0Rxj/mby78RpzZd0DrwsjE=; b=XcjVNT1pLebhXy+UdvAQJKmnsu 1Fq2eenWls2b4o9/iNIzUlzG3DQxEkDBb2PqG05NDIY+yHGtqGhJiDIGWcIu2le6oeBEmpLFdaKQq n0eXy6H+VI/PpRMTALPHJHFmg+AtN9oUNGDpApFr5Q2ZZuD7DIR0nzbaYUouso3jFu9UyICEGUJlt V0a4SOl14EOd0MC6efEEimeBojxF+iLMh0kgNDzzLZyhFdJ/D2nPeim6kRtiIw9eMfsrNsAXdElK1 8xg8q33mIBxDLpkEvpfJpS15rkdT5GhkZOXGgVgIGE7c4QIPFmOxQIacvZr+cpStSvtKaoOCo9SCk 0Sb9MFvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stpI1-00000008YwS-3Mel; Thu, 26 Sep 2024 14:16:17 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stpHz-00000008Yvs-0DuI for barebox@lists.infradead.org; Thu, 26 Sep 2024 14:16:16 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1stpHx-0006ci-Hf; Thu, 26 Sep 2024 16:16:13 +0200 Message-ID: <408551eb-5646-40b7-8679-1b63a20538c9@pengutronix.de> Date: Thu, 26 Sep 2024 16:16:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , "open list:BAREBOX" References: <20240926-vop2-v1-0-fe0581f2020b@pengutronix.de> <20240926-vop2-v1-7-fe0581f2020b@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20240926-vop2-v1-7-fe0581f2020b@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240926_071615_126419_5AA74D4E X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 07/13] video: Add Sitronix st7789v panel driver X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Sascha, On 26.09.24 15:15, Sascha Hauer wrote: > + ret = st7789v_read_data(ctx, MIPI_DCS_GET_DISPLAY_ID, ids, ST7789V_IDS_SIZE); > + if (ret) > + return ret; > +printf("%s: %02x %02x %02x\n", __func__, ids[0], ids[1], ids[2]); Debugging left-over. > +static int st7789v_prepare(struct st7789v *ctx) > +{ > + ret = regulator_enable(ctx->power); > + if (ret) > + return ret; > + > + gpiod_set_value(ctx->reset, 1); > + mdelay(30); > + gpiod_set_value(ctx->reset, 0); > + mdelay(120); Ouch. That's quite a bit of wasted time. Could it make sense to move device out of reset in probe function instead? Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |