mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] kbuild: allow overriding compression tools
Date: Tue, 21 Jan 2025 10:39:15 +0100	[thread overview]
Message-ID: <448072af-3a33-4c2e-8113-cadb379e79a9@pengutronix.de> (raw)
In-Reply-To: <Z49rHTam9hL1ikwU@pengutronix.de>

On 21.01.25 10:38, Sascha Hauer wrote:
> On Thu, Jan 16, 2025 at 03:09:24PM +0100, Ahmad Fatoum wrote:
>> barebox proper is usually compressed and this introduces a dependency on
>> an outside host tool depending on the chosen compression algo.
>>
>> So far, we expected the utility to be in PATH, but to allow build
>> systems to place it elsewhere, let's copy what Linux does and adopt a number
>> of Make variable that can be overridden from the outside.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  Makefile             |  6 ++++++
>>  scripts/Makefile.lib | 12 ++++++------
>>  scripts/xz_wrap.sh   |  5 +++--
>>  3 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 3487aba201b9..81cab701230e 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -440,6 +440,12 @@ PYTHON3		= python3
>>  CHECK		= sparse
>>  MKIMAGE		= mkimage
>>  BASH		= bash
>> +KGZIP		= gzip
>> +KBZIP2		= bzip2
>> +KLZOP		= lzop
>> +LZMA		= lzma
>> +LZ4		= lz4
>> +XZ		= xz
> 
> Added missing
> 
> export KGZIP KBZIP2 KLZOP LZMA LZ4 XZ
> 
> to make this patch work.

Thanks..

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2025-01-21  9:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 14:09 [PATCH 1/2] kbuild: allow overriding mkimage Ahmad Fatoum
2025-01-16 14:09 ` [PATCH 2/2] kbuild: allow overriding compression tools Ahmad Fatoum
2025-01-21  8:20   ` Sascha Hauer
2025-01-21  8:52     ` Ahmad Fatoum
2025-01-21  9:38   ` Sascha Hauer
2025-01-21  9:39     ` Ahmad Fatoum [this message]
2025-01-21  8:59 ` [PATCH 1/2] kbuild: allow overriding mkimage Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448072af-3a33-4c2e-8113-cadb379e79a9@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox