Re: [PATCH v2 2/2] i.MX: HAB: update text for HABV4_CSF_UNLOCK_UID

Sascha Hauer
2026-04-22T07:43:54Z

Hi Fabian,

On Wed, Apr 15, 2026 at 01:10:22PM +0200, Fabian Pflug wrote:
> With the establishment of global.soc_uid_hex, there is no need to look
> for the serial number and reverse it.
>
> Also some SoC's will have 128-bit UID's, so the hint to 64-bit is not
> correct and should be removed.
>
> Signed-off-by: Fabian Pflug <f.pflug@pengutronix.de>
> ---
> arch/arm/mach-imx/Kconfig | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 2e4d1ac80a..cb77d0d5b6 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -918,17 +918,12 @@ config HABV4_CSF_UNLOCK_UID
> depends on HABV4 && HABV4_CSF_UNLOCK_FIELD_RETURN
> string "CSF Unlock UID"
> help
> - Device specific 64-bit UID required to unlock the field-return
> + Device specific UID required to unlock the field-return
> feature. This value must match the per device UNIQUE_ID fuses.
>
> The below example shows the expected format. The UNIQUE_ID is
> - printed during boot by barebox:
> - i.MX___ unique ID: 7766554433221100
> - or it can be queried by Linux via:
> - - cat /sys/devices/soc0/serial_number
> - 7766554433221100

I don't think we should remove this. For some people it might be more
convenient to read the SoC UID from Linux or to parse it from the
barebox console log.

> -
> - So this value have to be set:
> + stored in $global.soc_uid_hex, but must be split into bytes.
> + The soc_uid_hex 0011223344556677 becomes:
> - 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77

By using soc_uid_hex we no longer have to reverse the byte order, but
still have to reformat it (split into bytes, add 0x and comma). I think
this little convenience gain is not worth the change really.

Sascha

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |