From: Alex Gershgorin <alexg@meprolight.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
Alex Gershgorin <alexgershgorin@gmail.com>
Subject: RE: [PATCH] video imx-ipu-fb: add clear screen
Date: Tue, 11 Sep 2012 13:14:06 +0300 [thread overview]
Message-ID: <4875438356E7CA4A8F2145FCD3E61C0B3074AA38FC@MEP-EXCH.meprolight.com> (raw)
In-Reply-To: <20120911074432.GH18243@pengutronix.de>
Hi Sascha,
On Mon, Sep 10, 2012 at 01:16:26PM +0300, Alex Gershgorin wrote:
> > Hi Sascha,
> >
> > On Fri, Sep 07, 2012 at 01:46:39PM +0300, Alex Gershgorin wrote:
> > > This patch clear screen before usage
> > >
> > > Signed-off-by: Alex Gershgorin <alexg@meprolight.com>
> > > ---
> > > drivers/video/imx-ipu-fb.c | 4 ++++
> > > 1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
> > > index 8039de0..d46cced 100644
> > > --- a/drivers/video/imx-ipu-fb.c
> > > +++ b/drivers/video/imx-ipu-fb.c
> > > @@ -1012,6 +1012,10 @@ static int imxfb_probe(struct device_d *dev)
> > > (info->bits_per_pixel >> 3));
> > > if (!fbi->info.screen_base)
> > > return -ENOMEM;
> > > +
> > > + /* Clear the screen */
> > > + memset((char *)fbi->info.screen_base, 0,
> > > + info->xres * info->yres * (info->bits_per_pixel >> 3));
> >
> > > > Not clearing the screen is intentional. Normally the fb drivers do not
> > > > enable the framebuffer until explicitely requested via fb0.enable=1. The
> > > > environment normally is supposed to set a picture on the screen and
> > > > enable it afterwards.
> > > > That said, we can clear the screen as with MMU enabled this probably
> > > > does not take long time. But then it should be done in the fb core.
> >
> > Thanks for your explanation.
> > In my case, I displayed picture on the screen, of course as you said I added to "init" script
> > fb0.enable = 1
> > bmp / env / logo.bmp
> I would exchange the above commands. I don't know how this looks on your
> hardware, but often enough it looks a lot nicer if you draw the logo
> first and enable the framebuffer (the backlight most importantly)
> afterwards.
Oh sorry it's my fault, but in the my script this written correctly :-)
> it was easy.
>
> The problem is that I have a screen with resolution 800x600, but
> picture that I displayed on the my screen is much smaller, resulting
> in a picture is displayed fine, but on the sides I get garbage. This
> patch fixes this issue, of course it is not the only way to solve this
> issue.
> Yes, I thought that. 'cp /dev/zero /dev/fb0' would be another solution.
> I think the memset in the fb code is fine, but it should be done in the
> generic code.
Thanks for this point I tested it, this work fine :-)
Regards,
Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-11 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 10:46 Alex Gershgorin
2012-09-07 12:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-10 7:36 ` Sascha Hauer
2012-09-10 10:16 ` Alex Gershgorin
2012-09-11 7:44 ` Sascha Hauer
2012-09-11 10:14 ` Alex Gershgorin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4875438356E7CA4A8F2145FCD3E61C0B3074AA38FC@MEP-EXCH.meprolight.com \
--to=alexg@meprolight.com \
--cc=alexgershgorin@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox