From: Markus Niebel <Markus.Niebel@tqs.de>
To: Alexander Aring <alex.aring@gmail.com>,
Markus Niebel <list-09_barebox@tqsc.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: AW: [PATCH 3/4] mci: imx-esdhc: add DSR support
Date: Tue, 14 Jan 2014 14:26:38 +0000 [thread overview]
Message-ID: <494049813E4FF84D8387DA057CCF83991A37F4E9@TQ-MAIL.tq-net.de> (raw)
In-Reply-To: <20140114084916.GA26300@omega>
Hello,
> Von: Alexander Aring [mailto:alex.aring@gmail.com]
> Gesendet: Dienstag, 14. Januar 2014 09:49
> An: Markus Niebel
> Cc: barebox@lists.infradead.org; Markus Niebel
> Betreff: Re: [PATCH 3/4] mci: imx-esdhc: add DSR support
>
> Hi,
>
> On Tue, Jan 14, 2014 at 09:23:36AM +0100, Markus Niebel wrote:
> > From: Markus Niebel <Markus.Niebel@tqs.de>
> >
> > having DSR support in mci-core we need a way to
> > forward the DSR value to the driver. Add it to
> > platform data for imx-esdhc
> >
> > TODO: implement the same for other host controller
> > drivers
> >
> > Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
> > ---
> > arch/arm/mach-imx/include/mach/esdhc.h | 2 ++
> > drivers/mci/imx-esdhc.c | 4 ++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/mach-imx/include/mach/esdhc.h b/arch/arm/mach-
> imx/include/mach/esdhc.h
> > index add1691..fb7380a 100644
> > --- a/arch/arm/mach-imx/include/mach/esdhc.h
> > +++ b/arch/arm/mach-imx/include/mach/esdhc.h
> > @@ -42,5 +42,7 @@ struct esdhc_platform_data {
> > enum cd_types cd_type;
> > unsigned caps;
> > char *devname;
> > + unsigned dsr_val;
> > + int use_dsr;
> > };
> > #endif /* __ASM_ARCH_IMX_ESDHC_H */
> > diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
> > index 7664e7b..4c7a45e 100644
> > --- a/drivers/mci/imx-esdhc.c
> > +++ b/drivers/mci/imx-esdhc.c
> > @@ -582,6 +582,10 @@ static int fsl_esdhc_probe(struct device_d *dev)
> > if (host->mci.f_min < 200000)
> > host->mci.f_min = 200000;
> > host->mci.f_max = rate;
> > + if (pdata) {
> > + host->mci.use_dsr = pdata->use_dsr;
> > + host->mci.dsr_val = pdata->dsr_val;
> > + }
> >
> I don't know what other barebox devs thinking about this. But I would
> remove use_dsr attribute, because a dsr_val != 0 indicates that you want
> to use dsr. You don't need a extra switch, in my opinion.
As far as I understand the documentation the assignment between DSR / CMD4 value
and driver strength is left to the card (firmware) implementor - so far a dsr_val = 0
could be a valid setting.
>
> - Alex
Markus
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-01-14 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:23 [PATCH v2 0/4] mmc: add setdsr support Markus Niebel
2014-01-14 8:23 ` [PATCH 1/4] mci: add DSR support Markus Niebel
2014-01-14 8:23 ` [PATCH 2/4] mci: add device tree support for DSR Markus Niebel
2014-01-14 8:23 ` [PATCH 3/4] mci: imx-esdhc: add DSR support Markus Niebel
2014-01-14 8:49 ` Alexander Aring
2014-01-14 14:26 ` Markus Niebel [this message]
2014-01-14 8:23 ` [PATCH 4/4] boards: tqma53: add DSR support for eMMC Markus Niebel
2014-01-15 14:23 ` [PATCH v2 0/4] mmc: add setdsr support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494049813E4FF84D8387DA057CCF83991A37F4E9@TQ-MAIL.tq-net.de \
--to=markus.niebel@tqs.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=list-09_barebox@tqsc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox