From: Nishanth Menon <menon.nishanth@gmail.com>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] omap3: 3430sdp: add choice of UARTs for console
Date: Mon, 05 Apr 2010 05:47:14 -0500 [thread overview]
Message-ID: <4BB9BFB2.9010807@gmail.com> (raw)
In-Reply-To: <1270458446-25073-1-git-send-email-gadiyar@ti.com>
On 04/05/2010 04:07 AM, Anand Gadiyar wrote:
> The OMAP3 SDPs have both UART1 and UART3 available.
> Historically, UART1 has been used for the console.
>
> Add a config option to select between these UARTs
> (along the lines of what has been done for OMAP3 EVM)
>
> Signed-off-by: Anand Gadiyar<gadiyar@ti.com>
> ---
> board/omap/Kconfig | 16 ++++++++++++++++
> board/omap/board-sdp343x.c | 4 ++++
> 2 files changed, 20 insertions(+)
>
> Index: barebox/board/omap/Kconfig
> ===================================================================
> --- barebox.orig/board/omap/Kconfig
> +++ barebox/board/omap/Kconfig
> @@ -61,6 +61,22 @@ config MACH_OMAP3EVM
>
> endchoice
>
> +if MACH_OMAP343xSDP
> + choice
> + prompt "Select UART"
> +
> + config OMAP343xSDP_UART1
> + bool "Use UART1"
> + help
> + Say Y here if you would like to use UART1 as console.
> +
> + config OMAP343xSDP_UART3
> + bool "Use UART3"
> + help
> + Say Y here if you would like to use UART1 as console.
> + endchoice
> +endif
> +
> if MACH_OMAP3EVM
> choice
> prompt "Select UART"
> Index: barebox/board/omap/board-sdp343x.c
> ===================================================================
> --- barebox.orig/board/omap/board-sdp343x.c
> +++ barebox/board/omap/board-sdp343x.c
> @@ -611,7 +611,11 @@ static struct NS16550_plat serial_plat =
>
> static struct device_d sdp3430_serial_device = {
> .name = "serial_ns16550",
> +#if defined(CONFIG_OMAP343xSDP_UART1)
> + .map_base = OMAP_UART1_BASE,
> +#elif defined(CONFIG_OMAP343xSDP_UART3)
> .map_base = OMAP_UART3_BASE,
> +#endif
> .size = 1024,
> .platform_data = (void *)&serial_plat,
> };
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
I dont see a major reason for supporting UART1 other than historical
reasons, as UART3 seems capable of doing more than just debug terminal
alone (includes download aswell).. overall I dont see an issue, but
might be better to choose the terminal in a generic manner accross
platforms - as in, CONFIG_OMAP_SERIAL_UART1,2,3... for all platforms -
just my 2 cents.
Regards,
Nishanth Menon
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-04-05 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 9:07 Anand Gadiyar
2010-04-05 9:07 ` [PATCH 1/3] omap3: rename defconfigs to align with kernel Anand Gadiyar
2010-04-05 9:07 ` [PATCH 3/3] omap3: 3430sdp: Update defconfig Anand Gadiyar
2010-04-05 10:48 ` Nishanth Menon
2010-04-05 10:41 ` [PATCH 1/3] omap3: rename defconfigs to align with kernel Nishanth Menon
2010-04-05 11:45 ` Gadiyar, Anand
2010-04-05 10:47 ` Nishanth Menon [this message]
2010-04-05 11:46 ` [PATCH 2/3] omap3: 3430sdp: add choice of UARTs for console Gadiyar, Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB9BFB2.9010807@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=gadiyar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox