From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/6] imx35pdk: make COMPARE pad a GPIO1_5 output
Date: Thu, 13 May 2010 13:21:27 +0200 [thread overview]
Message-ID: <4BEBE0B7.10303@pengutronix.de> (raw)
In-Reply-To: <1273718822-16800-7-git-send-email-marc@cpdesign.com.au>
[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]
Hello Marc,
Marc Reilly wrote:
> This pad is an interrupt source, active low for one of the external ICs.
just nitpicking from my side, see comments inline.
Cheers, Marc
> ---
> board/freescale-mx35-3-stack/3stack.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale-mx35-3-stack/3stack.c b/board/freescale-mx35-3-stack/3stack.c
> index 4dc25e6..797e517 100644
> --- a/board/freescale-mx35-3-stack/3stack.c
> +++ b/board/freescale-mx35-3-stack/3stack.c
> @@ -280,6 +280,8 @@ static struct pad_desc f3s_pads[] = {
> MX35_PAD_I2C1_DAT__I2C1_SDA,
>
> MX35_PAD_WDOG_RST__GPIO1_6,
> + MX35_PAD_COMPARE__GPIO1_5,
> +
no trailing whitespace, please
> /* Display */
> MX35_PAD_LD0__IPU_DISPB_DAT_0,
> MX35_PAD_LD1__IPU_DISPB_DAT_1,
> @@ -332,7 +334,7 @@ static int f3s_core_init(void)
> reg |= 0x3 << CCM_CGR1_FEC_SHIFT;
> reg |= 0x3 << CCM_CGR1_I2C1_SHIFT;
> reg = writel(reg, IMX_CCM_BASE + CCM_CGR1);
> -
> +
dito
> /* AIPS setup - Only setup MPROTx registers. The PACR default values are good.*/
> /*
> * Set all MPROTx to be non-bufferable, trusted for R/W,
> @@ -414,6 +416,9 @@ static int f3s_pmic_init_v2(struct mc13892 *mc13892)
> {
> int err = 0;
>
> + /* COMPARE pin (GPIO1_5) as output and set high */
> + gpio_direction_output( 32*0 + 5 , 1);
> +
dito
> err |= mc13892_set_bits(mc13892, MC13892_REG_SETTING_0, 0x03, 0x03);
> err |= mc13892_set_bits(mc13892, MC13892_REG_MODE_0, 0x01, 0x01);
> if (err)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-05-13 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 2:46 Ammended patches for imx35pdk boot Marc Reilly
2010-05-13 2:46 ` [PATCH 1/6] arm: Add revision tag to boot parameters Marc Reilly
2010-05-13 2:46 ` [PATCH 2/6] arm boot: Formatting Marc Reilly
2010-05-13 2:46 ` [PATCH 3/6] imx35: add detection of silicon revision Marc Reilly
2010-05-13 2:47 ` [PATCH 4/6] imx35pdk: correct mode for display contrast pin Marc Reilly
2010-05-13 2:47 ` [PATCH 5/6] imx35pdk: Detect and set silicon and board revision for boot params Marc Reilly
2010-05-13 2:47 ` [PATCH 6/6] imx35pdk: make COMPARE pad a GPIO1_5 output Marc Reilly
2010-05-13 11:21 ` Marc Kleine-Budde [this message]
2010-05-13 11:23 ` [PATCH 4/6] imx35pdk: correct mode for display contrast pin Marc Kleine-Budde
2010-05-13 11:27 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEBE0B7.10303@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox