From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/6] imx35pdk: correct mode for display contrast pin
Date: Thu, 13 May 2010 13:23:22 +0200 [thread overview]
Message-ID: <4BEBE12A.6020306@pengutronix.de> (raw)
In-Reply-To: <1273718822-16800-5-git-send-email-marc@cpdesign.com.au>
[-- Attachment #1.1: Type: text/plain, Size: 1567 bytes --]
Marc Reilly wrote:
Please don't forget to add you'r S-o-b.
Cheers, Marc
> ---
> board/freescale-mx35-3-stack/3stack.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/board/freescale-mx35-3-stack/3stack.c b/board/freescale-mx35-3-stack/3stack.c
> index fcb87cf..d09de65 100644
> --- a/board/freescale-mx35-3-stack/3stack.c
> +++ b/board/freescale-mx35-3-stack/3stack.c
> @@ -201,10 +201,8 @@ device_initcall(f3s_devices_init);
>
> static int f3s_enable_display(void)
> {
> - gpio_direction_output(1, 1);
> -
> /* Enable power to the LCD. (bit 6 hi.) */
> - mc9sdz60_set_bits( mc9sdz60_get(), MC9SDZ60_REG_GPIO_1, 0x40, 0x40);
> + mc9sdz60_set_bits(mc9sdz60_get(), MC9SDZ60_REG_GPIO_1, 0x40, 0x40);
>
> return 0;
> }
> @@ -270,10 +268,11 @@ static struct pad_desc f3s_pads[] = {
> MX35_PAD_D3_HSYNC__IPU_DISPB_D3_HSYNC,
> MX35_PAD_D3_FPSHIFT__IPU_DISPB_D3_CLK,
> MX35_PAD_D3_DRDY__IPU_DISPB_D3_DRDY,
> - MX35_PAD_CONTRAST__GPIO1_1,
> + MX35_PAD_CONTRAST__IPU_DISPB_CONTR,
> MX35_PAD_D3_VSYNC__IPU_DISPB_D3_VSYNC,
> MX35_PAD_D3_REV__IPU_DISPB_D3_REV,
> MX35_PAD_D3_CLS__IPU_DISPB_D3_CLS,
> +
IMHO no need for this line, please remove.
> };
>
> static int f3s_console_init(void)
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-05-13 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 2:46 Ammended patches for imx35pdk boot Marc Reilly
2010-05-13 2:46 ` [PATCH 1/6] arm: Add revision tag to boot parameters Marc Reilly
2010-05-13 2:46 ` [PATCH 2/6] arm boot: Formatting Marc Reilly
2010-05-13 2:46 ` [PATCH 3/6] imx35: add detection of silicon revision Marc Reilly
2010-05-13 2:47 ` [PATCH 4/6] imx35pdk: correct mode for display contrast pin Marc Reilly
2010-05-13 2:47 ` [PATCH 5/6] imx35pdk: Detect and set silicon and board revision for boot params Marc Reilly
2010-05-13 2:47 ` [PATCH 6/6] imx35pdk: make COMPARE pad a GPIO1_5 output Marc Reilly
2010-05-13 11:21 ` Marc Kleine-Budde
2010-05-13 11:23 ` Marc Kleine-Budde [this message]
2010-05-13 11:27 ` [PATCH 4/6] imx35pdk: correct mode for display contrast pin Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEBE12A.6020306@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox