From: "Eric Bénard" <eric@eukrea.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 06/10] eukrea_cpuimx25: update board support
Date: Wed, 20 Oct 2010 12:43:19 +0200 [thread overview]
Message-ID: <4CBEC7C7.1040301@eukrea.com> (raw)
In-Reply-To: <20101016190102.GD6225@tarshish>
Hi Baruch,
Le 16/10/2010 21:01, Baruch Siach a écrit :
>> +#ifdef CONFIG_USB
>> +
>> +#define MX35_H1_SIC_SHIFT 21
>> +#define MX35_H1_SIC_MASK (0x3<< MX35_H1_SIC_SHIFT)
>> +#define MX35_H1_PM_BIT (1<< 8)
>> +#define MX35_H1_IPPUE_UP_BIT (1<< 7)
>> +#define MX35_H1_IPPUE_DOWN_BIT (1<< 6)
>> +#define MX35_H1_TLL_BIT (1<< 5)
>> +#define MX35_H1_USBTE_BIT (1<< 4)
>> +#define MXC_EHCI_INTERFACE_SINGLE_UNI (2<< 0)
>
> The exact same defines appear in patch no. 10 of this series. IMO these should
> go into a shared header file.
>
done, thanks for the review.
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-10-20 10:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 14:05 [PATCH 01/10] imx/clocksource: enable GPT1 before using it on CPUIMX25 Eric Bénard
2010-10-14 14:05 ` [PATCH 02/10] mx25: add MMC clock support Eric Bénard
2010-10-14 14:05 ` [PATCH 03/10] MX25: fix IOMUX for ESDHC1 pins Eric Bénard
2010-10-14 14:05 ` [PATCH 04/10] mci-core: add more tested SD Cards Eric Bénard
2010-10-14 14:05 ` [PATCH 05/10] epautoconf: fix compile error Eric Bénard
2010-10-14 14:05 ` [PATCH 06/10] eukrea_cpuimx25: update board support Eric Bénard
2010-10-16 19:01 ` Baruch Siach
2010-10-20 10:43 ` Eric Bénard [this message]
2010-10-14 14:05 ` [PATCH 07/10] imx35-regs: add defines for USB and SD Eric Bénard
2010-10-14 14:05 ` [PATCH 08/10] speed-imx35: add support for SDHC1 Eric Bénard
2010-10-14 14:05 ` [PATCH 09/10] iomux-mx35: fox IOMUX for SDHC1's pins Eric Bénard
2010-10-14 14:05 ` [PATCH 10/10] eukrea_cpuimx35: update board support Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBEC7C7.1040301@eukrea.com \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
--cc=baruch@tkos.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox