mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] defaultenv/bin/boot: fix ubi root's name assignment
Date: Wed, 02 Feb 2011 23:14:08 +0100	[thread overview]
Message-ID: <4D49D730.3040009@eukrea.com> (raw)
In-Reply-To: <1296684558-16821-1-git-send-email-mkl@pengutronix.de>

On 02/02/2011 23:09, Marc Kleine-Budde wrote:
> This patch fixes a regression introduced in commit
> d15cfafeef8f99ff1a47e77362d0adf1b07f26ae.
>
> While there, use "-z" to check if ubiroot variable is empty.
>
> Signed-off-by: Marc Kleine-Budde<mkl@pengutronix.de>
> Cc: Eric B�nard<eric@eukrea.com>
Acked-By: Eric Bénard<eric@eukrea.com>

and shame on me for not testing this part ...

Eric
> ---
>   defaultenv/bin/boot |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/defaultenv/bin/boot b/defaultenv/bin/boot
> index fa68748..788a781 100644
> --- a/defaultenv/bin/boot
> +++ b/defaultenv/bin/boot
> @@ -34,8 +34,8 @@ else
>   	fi
>
>   	if [ x$rootfs_type = xubifs ]; then
> -		if [ x$ubiroot = x ]; then
> -			ubiroot = "root"
> +		if [ -z $ubiroot ]; then
> +			ubiroot="root"
>   		fi
>   		bootargs="$bootargs root=ubi0:$ubiroot ubi.mtd=$rootfs_mtdblock"
>   	else


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-02-02 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02 22:09 Marc Kleine-Budde
2011-02-02 22:14 ` Eric Bénard [this message]
2011-02-02 22:18   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D49D730.3040009@eukrea.com \
    --to=eric@eukrea.com \
    --cc=barebox@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox