[PATCH 1/1] freescale-mx35-3-stack: Add mmc0

[PATCH 1/1] freescale-mx35-3-stack: Add mmc0

[Thomas Mayer]

Signed-off-by: Thomas Mayer <thomas.mayer@telemotive.de>
---
 arch/arm/boards/freescale-mx35-3-stack/3stack.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boards/freescale-mx35-3-stack/3stack.c b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
index 127bfb4..a4cbbe1 100644
--- a/arch/arm/boards/freescale-mx35-3-stack/3stack.c
+++ b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
@@ -199,6 +199,10 @@ static int f3s_devices_init(void)
 		break;
 	}
 
+#ifdef CONFIG_MCI_IMX_ESDHC
+	imx35_add_mmc0(NULL);
+#endif
+
 	set_silicon_rev(imx_silicon_revision());
 
 	i2c_register_board_info(0, i2c_devices, ARRAY_SIZE(i2c_devices));
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] freescale-mx35-3-stack: Add mmc0

[Sascha Hauer]

Hi Thomas,

On Thu, Apr 07, 2011 at 09:57:19AM +0200, Thomas Mayer wrote:
> 
> Signed-off-by: Thomas Mayer <thomas.mayer@telemotive.de>
> ---
>  arch/arm/boards/freescale-mx35-3-stack/3stack.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boards/freescale-mx35-3-stack/3stack.c b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
> index 127bfb4..a4cbbe1 100644
> --- a/arch/arm/boards/freescale-mx35-3-stack/3stack.c
> +++ b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
> @@ -199,6 +199,10 @@ static int f3s_devices_init(void)
>  		break;
>  	}
>  
> +#ifdef CONFIG_MCI_IMX_ESDHC
> +	imx35_add_mmc0(NULL);
> +#endif

No ifdef here, please. Registering a device without a driver available
doesn't hurt, except for a few bytes of binary space.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] freescale-mx35-3-stack: Add mmc0

[Thomas Mayer]

Hi Sascha,

Am 08.04.2011 08:41, schrieb Sascha Hauer:
> Hi Thomas,
>
> On Thu, Apr 07, 2011 at 09:57:19AM +0200, Thomas Mayer wrote:
>> Signed-off-by: Thomas Mayer<thomas.mayer@telemotive.de>
>> ---
>>   arch/arm/boards/freescale-mx35-3-stack/3stack.c |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boards/freescale-mx35-3-stack/3stack.c b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> index 127bfb4..a4cbbe1 100644
>> --- a/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> +++ b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> @@ -199,6 +199,10 @@ static int f3s_devices_init(void)
>>   		break;
>>   	}
>>
>> +#ifdef CONFIG_MCI_IMX_ESDHC
>> +	imx35_add_mmc0(NULL);
>> +#endif
> No ifdef here, please. Registering a device without a driver available
> doesn't hurt, except for a few bytes of binary space.
>
thanks for the advice. New patch is on the way...

Regards,
Thomas

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 1/1] freescale-mx35-3-stack: Add mmc0

[Thomas Mayer]

Signed-off-by: Thomas Mayer <thomas.mayer@telemotive.de>
---
 arch/arm/boards/freescale-mx35-3-stack/3stack.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boards/freescale-mx35-3-stack/3stack.c b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
index 127bfb4..03960a4 100644
--- a/arch/arm/boards/freescale-mx35-3-stack/3stack.c
+++ b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
@@ -207,6 +207,8 @@ static int f3s_devices_init(void)
 	imx35_add_fec(&fec_info);
 	register_device(&smc911x_dev);
 
+	imx35_add_mmc0(NULL);
+
 	register_device(&sdram_dev);
 	imx35_add_fb(&ipu_fb_data);
 
-- 
1.7.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox