From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] Clean up Kconfig and source for a couple device tree commands.
Date: Mon, 7 Jul 2014 14:39:32 +0800 [thread overview]
Message-ID: <4DA026CE-D019-4CBB-B46B-834064F91333@jcrosoft.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1407041217080.16169@localhost>
On Jul 5, 2014, at 12:18 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>
> Correct options listings for a couple device tree-related commands.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> i *think* the following is valid.
>
> diff --git a/commands/Kconfig b/commands/Kconfig
> index eed6fbd..3248de9 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -1950,10 +1950,11 @@ config CMD_OFTREE
> help
> oftree - handle device trees
>
> - Usage: oftree [-lpfdn] [DTB]
> + Usage: oftree [-lspf] [DTB]
>
> Options:
> -l Load DTB to internal device tree
> + -s save internal device tree to DTB
> -p probe devices from stored device tree
> -f free stored device tree
>
do we really need the help here
it’s a pain in the ass to keep it sync
> diff --git a/commands/of_dump.c b/commands/of_dump.c
> index e341942..cafde07 100644
> --- a/commands/of_dump.c
> +++ b/commands/of_dump.c
> @@ -101,7 +101,7 @@ BAREBOX_CMD_HELP_END
> BAREBOX_CMD_START(of_dump)
> .cmd = do_of_dump,
> BAREBOX_CMD_DESC("dump devicetree nodes")
> - BAREBOX_CMD_OPTS("[-f]")
> + BAREBOX_CMD_OPTS("[-f] [NODE]")
> BAREBOX_CMD_GROUP(CMD_GRP_MISC)
> BAREBOX_CMD_COMPLETE(devicetree_file_complete)
> BAREBOX_CMD_HELP(cmd_of_dump_help)
> diff --git a/commands/oftree.c b/commands/oftree.c
> index a3b0e04..983a0a5 100644
> --- a/commands/oftree.c
> +++ b/commands/oftree.c
> @@ -145,7 +145,7 @@ BAREBOX_CMD_HELP_END
> BAREBOX_CMD_START(oftree)
> .cmd = do_oftree,
> BAREBOX_CMD_DESC("handle device trees")
> - BAREBOX_CMD_OPTS("[-lpfs]")
> + BAREBOX_CMD_OPTS("[-lspf]")
> BAREBOX_CMD_GROUP(CMD_GRP_MISC)
> BAREBOX_CMD_HELP(cmd_oftree_help)
> BAREBOX_CMD_END
>
> --
>
> ========================================================================
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter: http://twitter.com/rpjday
> LinkedIn: http://ca.linkedin.com/in/rpjday
> ========================================================================
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-07 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 16:18 Robert P. J. Day
2014-07-07 6:35 ` Sascha Hauer
2014-07-07 6:39 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2014-07-07 9:11 ` Robert P. J. Day
2014-07-07 18:09 ` Jean-Christophe PLAGNIOL-VILLARD
2014-07-07 21:10 ` Holger Schurig
2014-07-07 10:07 ` Robert P. J. Day
2014-07-07 12:07 ` Sascha Hauer
2014-07-07 21:11 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA026CE-D019-4CBB-B46B-834064F91333@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox