From: Alexey Galakhov <agalakhov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fix console fifo (and loadb/loady commands)
Date: Mon, 16 May 2011 12:53:42 +0600 [thread overview]
Message-ID: <4DD0C9F6.6050407@gmail.com> (raw)
In-Reply-To: <20110516063018.GC30963@pengutronix.de>
On 05/16/2011 12:30 PM, Sascha Hauer wrote:
> Hi Alexey,
>
> On Fri, May 13, 2011 at 07:53:29PM +0600, Alexey Galakhov wrote:
>> This patch fixes loadb and loady commands. tstc() should return true if
>> console_input_buffer is not empty.
> The patch is fine, thanks.
>
> Your mailer converts tabs into whitespaces. Also you forgot to add a
> signed-off-by to your patch. I fixed this up manually this time.
>
> Sascha
Thank you! I'll check my mailer.
I'm preparing some more patches: s3c framebuffer support (originally
written by Juergen Beisert but broken and outdated), mini2440
framebuffer support and JPEG image decoding (takes about 20kB of space
by itself but reduces overall size significantly due to smaller image
files).
--
Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-05-16 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 13:31 loadb and loady do not work Alexey Galakhov
2011-05-13 13:53 ` [PATCH] fix console fifo (and loadb/loady commands) Alexey Galakhov
2011-05-16 6:30 ` Sascha Hauer
2011-05-16 6:53 ` Alexey Galakhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD0C9F6.6050407@gmail.com \
--to=agalakhov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox