From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq
Date: Thu, 28 Jul 2011 16:11:06 +0200 [thread overview]
Message-ID: <4E316DFA.6060009@pengutronix.de> (raw)
In-Reply-To: <1311858854-23434-2-git-send-email-t.gamez@phytec.de>
[-- Attachment #1.1: Type: text/plain, Size: 1865 bytes --]
On 07/28/2011 03:14 PM, Teresa Gámez wrote:
> Instead of changing the MPCTL to set an other cpu frequency,
> use the post divider.
>
> This prevents freezing when changing the clock from 399MHz to 532MHz.
>
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
> ---
> arch/arm/boards/pcm043/pcm043.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boards/pcm043/pcm043.c b/arch/arm/boards/pcm043/pcm043.c
> index 3bd6402..8629ae6 100644
> --- a/arch/arm/boards/pcm043/pcm043.c
> +++ b/arch/arm/boards/pcm043/pcm043.c
> @@ -308,8 +308,8 @@ static int pcm043_core_setup(void)
>
> core_initcall(pcm043_core_setup);
>
> -#define MPCTL_PARAM_399 (IMX_PLL_PD(0) | IMX_PLL_MFD(15) | IMX_PLL_MFI(8) | IMX_PLL_MFN(5))
> -#define MPCTL_PARAM_532 ((1 << 31) | IMX_PLL_PD(0) | IMX_PLL_MFD(11) | IMX_PLL_MFI(11) | IMX_PLL_MFN(1))
> +#define CCM_PDR0_PARAM_399 ((1 << 12) | (1 << 16))
> +#define CCM_PDR0_PARAM_532 (1 << 12)
nickpick: no tab after #define, please
Marc
>
> static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
> {
> @@ -322,10 +322,10 @@ static int do_cpufreq(struct command *cmdtp, int argc, char *argv[])
>
> switch (freq) {
> case 399:
> - writel(MPCTL_PARAM_399, IMX_CCM_BASE + CCM_MPCTL);
> + writel(CCM_PDR0_PARAM_399, IMX_CCM_BASE + CCM_PDR0);
> break;
> case 532:
> - writel(MPCTL_PARAM_532, IMX_CCM_BASE + CCM_MPCTL);
> + writel(CCM_PDR0_PARAM_532, IMX_CCM_BASE + CCM_PDR0);
> break;
> default:
> return COMMAND_ERROR_USAGE;
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-07-28 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 13:14 [PATCH 1/2] ARM pcm043: New RAM timings Teresa Gámez
2011-07-28 13:14 ` [PATCH 2/2] ARM pcm043: Use PDR0 to change cpu freq Teresa Gámez
2011-07-28 14:11 ` Marc Kleine-Budde [this message]
2011-07-28 13:43 ` [PATCH 1/2] ARM pcm043: New RAM timings Sascha Hauer
2011-08-22 13:49 ` Teresa Gamez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E316DFA.6060009@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox