From: Rosen Kolev <rosen.kolev@amk-drives.bg>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: USB mass storage support
Date: Thu, 29 Sep 2011 18:26:49 +0300 [thread overview]
Message-ID: <4E848E39.2050106@amk-drives.bg> (raw)
In-Reply-To: <CAA4bVAE6DSfAmZnrHLAaMOP2KZkjfqfRZZo8XrQkAG5FsMt_zQ@mail.gmail.com>
Hi Antony,
On 29.9.2011 г. 16:50 ч., Antony Pavlov wrote:
> On 28 September 2011 11:15, Sascha Hauer<s.hauer@pengutronix.de> wrote:
>> On Fri, Sep 23, 2011 at 08:57:43AM +0200, Sascha Hauer wrote:
>>> Hi,
>>>
>>> The following adds USB mass storage support to barebox. The patches
>>> are from Rosen Kolev, I am just sending these patches for him because
>>> git send-email does not work for him (yet).
>>>
>>> Sascha
>>>
>>> Rosen Kolev (3):
>>> Modified timeout in the ehci-hcd USB host driver.
>>> Extended USB device matching.
>>> USB mass storage device driver initial implementation
>> I merged this as-is. There are still some minor things like CamelCase
>> function names but overall This looked to good to not merge it ;)
> This patches have no "Signed-off-by :" label.
>
> I have tried them with 2 USB-flash drives on my Tegra board:
>
> toshiba ac100> / usb
> USB: scanning bus for devices...
> Bus 001 Device 003: ID 0bdb:190a F3307
> Bus 001 Device 004: ID 0bda:58f2 USB Camera
> Bus 001 Device 006: ID 8564:1000 Mass Storage Device
> disk@disk0: Failed to register partition disk0.1 (-22)
> Bus 001 Device 007: ID 067b:2303 USB-Serial Controller
> Bus 001 Device 008: ID 8564:1000 Mass Storage Device
> register_device: already registered disk0
> Bus 001 Device 009: ID 2001:3c05 DUB-E100
> eth@eth0: got MAC address from EEPROM: 1C:7E:E5:0F:E1:14
> Bus 001 Device 005: ID 05e3:0660 USB2.0 Hub
> Bus 001 Device 002: ID 0424:2513
> Bus 001 Device 001: ID 0000:0000 EHCI Host Controller
> 9 USB Device(s) found
>
> Can we register more that one disk?
>
We were supposed to, but you have just found an omission. In function
usb_stor_add_blkdev(), we need "pdev->id = -1;", e.g. right after "pdev
= &pblk_dev->dev;".
The first error, "Failed to register partition...", probably has
something to do with the partition table. Keep in mind that the disk
driver currently supports up to 2GB partitions.
Regards,
Rosen
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-09-29 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 6:57 Sascha Hauer
2011-09-23 6:57 ` [PATCH 1/3] Modified timeout in the ehci-hcd USB host driver Sascha Hauer
2011-09-23 6:57 ` [PATCH 2/3] Extended USB device matching Sascha Hauer
2011-09-23 6:57 ` [PATCH 3/3] USB mass storage device driver initial implementation Sascha Hauer
2011-09-23 7:10 ` USB mass storage support Robert Schwebel
2011-09-28 7:15 ` Sascha Hauer
2011-09-29 13:50 ` Antony Pavlov
2011-09-29 15:26 ` Rosen Kolev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E848E39.2050106@amk-drives.bg \
--to=rosen.kolev@amk-drives.bg \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox