From: Alexey Galakhov <agalakhov@gmail.com>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] Fine split S3C arch dependencies from generic code
Date: Fri, 04 May 2012 15:39:10 +0600 [thread overview]
Message-ID: <4FA3A3BE.2040607@gmail.com> (raw)
In-Reply-To: <201205031941.00662.jbe@pengutronix.de>
On 03.05.2012 23:41, Juergen Beisert wrote:
>> create mode 100644 arch/arm/mach-samsung/include/mach/s3c-nand.h
>> delete mode 100644 arch/arm/mach-samsung/include/mach/s3c24xx-nand.h
>
> That is a really bad idea. I just renamed these files at January 2012 to reflect
> their CPU (refer b29b8f43d56b62e406349a5cf1ed56f17454c1f7). Why do you revert
> this change again? The NAND controller in the S3C24XX CPU is unique to this
> CPU. The NAND controller in the S3C6410 differs from it, and I guess the same
> is true in the S5 CPU. So, the newer CPUs need their own NAND drivers.
>
> What is the sense of renaming these files?
In fact, exactly the opposite is true. The NAND controller in S5PV210 is
almost exactly the same as in S3C24xx. The only difference is the
numbering of registers. Also S5P suports 1-bit and 4-bit HW ECC while
S3C has only 1-bit. The algorithm is the same, even
s3c2440_nand_read_buf() works correctly.
S3C6410 has the same controller as well.
Right now I have working S5PV210 NAND driver, I did it like that:
#ifdef CONFIG_ARCH_S5PCxx
#define NFCONT 0x04
#define NFCMD 0x08
#define NFADDR 0x0C
#define NFDATA 0x10
#define NFSTAT 0x28
#define NFECC 0x34
etc.
The driver IS the same, yes. It works for both S5P and S3C.
Regards,
Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-04 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 13:14 [PATCH 0/4] Support Samsung S5PV210 CPU Alexey Galakhov
2012-05-03 13:14 ` [PATCH 1/4] Support most Samsung SoCs in S3C serial driver Alexey Galakhov
2012-05-03 13:14 ` [PATCH 2/4] Fine split S3C arch dependencies from generic code Alexey Galakhov
2012-05-03 17:41 ` Juergen Beisert
2012-05-04 9:39 ` Alexey Galakhov [this message]
2012-05-04 9:58 ` Juergen Beisert
2012-05-04 10:50 ` Alexey Galakhov
2012-05-04 11:13 ` Juergen Beisert
2012-05-04 11:26 ` missing sscanf christian.buettner
2012-05-04 11:40 ` [PATCH 2/4] Fine split S3C arch dependencies from generic code Alexey Galakhov
2012-05-04 12:00 ` Juergen Beisert
2012-05-04 12:34 ` Alexey Galakhov
2012-05-04 10:52 ` Alexey Galakhov
2012-05-03 13:14 ` [PATCH 3/4] Minimal S5PV210 + Tiny210 support (2nd stage only) Alexey Galakhov
2012-05-03 17:49 ` Juergen Beisert
2012-05-04 9:41 ` Alexey Galakhov
2012-05-03 13:14 ` [PATCH 4/4] S5PV210 iROM magic boot code Alexey Galakhov
2012-05-03 17:59 ` Juergen Beisert
2012-05-04 9:47 ` Alexey Galakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA3A3BE.2040607@gmail.com \
--to=agalakhov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox