Re: [PATCH] ARM: karo-tx6: enable deep-probe

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 11/11/25 12:49 PM, Fabian Pfitzner wrote:

Please write commit messages, e.g.,

We have two baseboards using this SoM mainline sharing the same board
code that is not yet deep probe compatible, because they expect i2c0 to
be available at device_initcall level.

Make the board code deep probe compatible and enable deep probe for all
boards using this SoM. Out-of-tree board code will need to adapt
accordingly, so note that in the migration guide.



> Signed-off-by: Fabian Pfitzner <f.pfitzner@pengutronix.de>
> ---
>  Documentation/migration-guides/migration-2025.11.0.rst | 4 ++++
>  arch/arm/boards/karo-tx6x/board.c                      | 2 ++
>  arch/arm/dts/imx6dl-tx6u.dts                           | 2 +-
>  arch/arm/dts/imx6q-tx6q.dts                            | 2 +-
>  4 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/migration-guides/migration-2025.11.0.rst b/Documentation/migration-guides/migration-2025.11.0.rst
> index a9c7abb66e..fa8140f615 100644
> --- a/Documentation/migration-guides/migration-2025.11.0.rst
> +++ b/Documentation/migration-guides/migration-2025.11.0.rst
> @@ -18,3 +18,7 @@ Karo TX6X
>  The barebox update handler for this SoM no longer unconditionally updates
>  /dev/mmc3.boot0, but instead it now updates the inactive boot partition
>  on /dev/mmc3 and then sets it as active allowing for power-fail safety.
> +
> +Deep probe has been enabled for this board. Out-of-tree board code for these
> +SoMs must either ensure devices are available as the in-tree code does or they
> +should add ``barebox,disable-deep-probe`` to their top level device tree node.

This will probably not be part of v2025.11.0, can you add this (with a
heading) to Documentation/migration-guides/migration-master.rst instead?

It will then land in the appropriate release.

Thanks,
Ahmad

> diff --git a/arch/arm/boards/karo-tx6x/board.c b/arch/arm/boards/karo-tx6x/board.c
> index 43e23f00cd..1924660c11 100644
> --- a/arch/arm/boards/karo-tx6x/board.c
> +++ b/arch/arm/boards/karo-tx6x/board.c
> @@ -54,6 +54,8 @@ static int setup_pmic_voltages(void)
>  	int bus = 0;
>  	uint8_t reg;
>  
> +	of_device_ensure_probed_by_alias("i2c0");
> +
>  	adapter = i2c_get_adapter(bus);
>  	if (!adapter) {
>  		pr_err("i2c bus %d not found\n", bus);
> diff --git a/arch/arm/dts/imx6dl-tx6u.dts b/arch/arm/dts/imx6dl-tx6u.dts
> index 1055de9d80..c23673d729 100644
> --- a/arch/arm/dts/imx6dl-tx6u.dts
> +++ b/arch/arm/dts/imx6dl-tx6u.dts
> @@ -8,6 +8,6 @@
>  / {
>  	model = "Ka-Ro electronics TX6U-801x Module";
>  	compatible = "karo,imx6dl-tx6dl", "fsl,imx6dl";
> -	barebox,disable-deep-probe;
> +	barebox,deep-probe;
>  };
>  
> diff --git a/arch/arm/dts/imx6q-tx6q.dts b/arch/arm/dts/imx6q-tx6q.dts
> index c2aacfc415..daf9549ea5 100644
> --- a/arch/arm/dts/imx6q-tx6q.dts
> +++ b/arch/arm/dts/imx6q-tx6q.dts
> @@ -8,6 +8,6 @@
>  / {
>  	model = "Ka-Ro electronics TX6Q Module";
>  	compatible = "karo,imx6q-tx6q", "fsl,imx6q";
> -	barebox,disable-deep-probe;
> +	barebox,deep-probe;
>  };
>  

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |